From: David Miller <davem@davemloft.net>
To: gaofeng@cn.fujitsu.com
Cc: netdev@vger.kernel.org, pablo@netfilter.org, edumazet@google.com,
kaber@trash.net, hannes@stressinduktion.org
Subject: Re: [PATCH] veth: allow to setup multicast address for veth device
Date: Wed, 09 Oct 2013 13:22:57 -0400 (EDT) [thread overview]
Message-ID: <20131009.132257.575792692083710085.davem@davemloft.net> (raw)
In-Reply-To: <52551ABD.40603@cn.fujitsu.com>
From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Wed, 09 Oct 2013 16:58:37 +0800
> Hi David,
>
> On 10/04/2013 04:52 PM, Gao feng wrote:
>> We can only setup multicast address for network device when
>> net_device_ops->ndo_set_rx_mode is not null.
>>
>> Some configurations need to add multicast address for net
>> device, such as netfilter cluster match module.
>>
>> Add a fake ndo_set_rx_mode function to allow this operation.
>>
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>
> I see this patch being marked as "Changes Requested" on patchwork.
> Is there something I missed?
It was a mistake, I put it back in Under Review.
next prev parent reply other threads:[~2013-10-09 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 8:52 [PATCH] veth: allow to setup multicast address for veth device Gao feng
2013-10-09 8:58 ` Gao feng
2013-10-09 17:22 ` David Miller [this message]
2013-10-10 4:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009.132257.575792692083710085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=hannes@stressinduktion.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).