From: Simon Horman <horms@verge.net.au>
To: Nguyen Hong Ky <nh-ky@jinso.co.jp>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Ryusuke Sakato <ryusuke.sakato.bx@renesas.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740
Date: Wed, 9 Oct 2013 14:26:17 +0900 [thread overview]
Message-ID: <20131009052617.GC16885@verge.net.au> (raw)
In-Reply-To: <20131009042826.GB16885@verge.net.au>
On Wed, Oct 09, 2013 at 01:28:26PM +0900, Simon Horman wrote:
> On Mon, Oct 07, 2013 at 03:29:25PM +0900, Nguyen Hong Ky wrote:
> > This patch will fix RX packets errors when receiving big size
> > of data by set bit RNC = 1.
> >
> > RNC - Receive Enable Control
> >
> > 0: Upon completion of reception of one frame, the E-DMAC writes
> > the receive status to the descriptor and clears the RR bit in
> > EDRRR to 0.
> >
> > 1: Upon completion of reception of one frame, the E-DMAC writes
> > (writes back) the receive status to the descriptor. In addition,
> > the E-DMAC reads the next descriptor and prepares for reception
> > of the next frame.
> >
> > In addition, for get more stable when receiving packets, I set
> > maximum size for the transmit/receive FIFO and inserts padding
> > in receive data.
> >
> > Signed-off-by: Nguyen Hong Ky <nh-ky@jinso.co.jp>
>
> I realise that this patch has been applied but regardless
> I would like to acknowledge that it resolve a problem that
> I observed this afternoon.
>
> Without this patch I see the following on the console, many times:
>
> net eth0: Receive FIFO Overflow
>
> With this patch I do not see the warning message at all.
Scratch that, I am still seeing the messages with this patch applied.
next prev parent reply other threads:[~2013-10-09 5:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 6:29 [PATCH] net: sh_eth: Fix RX packets errors on R8A7740 Nguyen Hong Ky
2013-10-07 6:29 ` Nguyen Hong Ky
2013-10-09 4:28 ` Simon Horman
2013-10-09 5:26 ` Simon Horman [this message]
2013-10-09 5:38 ` Nguyen Hong Ky
2013-10-10 5:29 ` Simon Horman
2013-10-12 16:58 ` Sergei Shtylyov
2013-10-15 7:28 ` Guennadi Liakhovetski
2013-10-15 21:48 ` Sergei Shtylyov
2013-10-16 5:37 ` Guennadi Liakhovetski
2013-10-08 20:04 ` David Miller
2013-10-09 4:24 ` Simon Horman
2013-10-09 20:27 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009052617.GC16885@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nh-ky@jinso.co.jp \
--cc=ryusuke.sakato.bx@renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).