From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH v2 tip/core/rcu 05/13] decnet: Apply rcu_access_pointer() to avoid sparse false positive Date: Wed, 9 Oct 2013 16:54:11 -0700 Message-ID: <20131009235411.GH5790@linux.vnet.ibm.com> References: <20131009212920.GA15413@linux.vnet.ibm.com> <1381354186-16285-1-git-send-email-paulmck@linux.vnet.ibm.com> <1381354186-16285-5-git-send-email-paulmck@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: LKML , mingo@kernel.org, laijs@cn.fujitsu.com, Dipankar , Andrew Morton , Mathieu Desnoyers , josh@joshtriplett.org, Nivedita Singhvi , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , edumazet@google.com, Darren Hart , Frederic Weisbecker , sbw@mit.edu, "David S. Miller" , Thomas Graf , Gao feng , Stephen Hemminger , linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org To: Dhaval Giani Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Oct 09, 2013 at 06:58:47PM -0400, Dhaval Giani wrote: > On Wed, Oct 9, 2013 at 5:29 PM, Paul E. McKenney > wrote: > > > > From: "Paul E. McKenney" > > > > The sparse checking for rcu_assign_pointer() was recently upgraded > > to reject non-__kernel address spaces. This also rejects __rcu, > > which is almost always the right thing to do. However, the use in > > dn_insert_route() is legitimate: It is assigning a pointer to an element > > from an RCU-protected list, and all elements of this list are already > > visible to caller. > > > > This commit therefore silences this false positive by laundering the > > pointer using rcu_access_pointer() as suggested by Josh Triplett. > > > > Reported-by: kbuild test robot > > I did not realize that we were allowed to rename people :-) Copied and pasted directly from the email I received. Perhaps strange, but true! ;-) Thanx, Paul