From: Steffen Klassert <steffen.klassert@secunet.com>
To: netdev@vger.kernel.org
Subject: [PATCH RFC 0/2] xfrm: Remove ancient sleeping code
Date: Thu, 10 Oct 2013 08:33:01 +0200 [thread overview]
Message-ID: <20131010063301.GO7660@secunet.com> (raw)
Does anyone still rely on the ancient sleeping when the SA is in
acquire state? It is disabled by default since more that five years,
but can cause indefinite task hangs if enabled and the needed state
does not get resolved.
We now queue packets to the policy if the states are not yet resolved
if we are in a code path that can not sleep. We could do this even in
the case we can sleep. As a bonus, we can remove the FLOWI_FLAG_CAN_SLEEP
flag because the only thing this flag does, is to notify xfrm that we are
in a codepath that can sleep.
The two RFC patches to remove the sleeping code are in reply to this
mail. I'd add this to the ipsec-next tree if there are no objections.
next reply other threads:[~2013-10-10 6:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 6:33 Steffen Klassert [this message]
2013-10-10 6:33 ` [PATCH RFC 1/2] xfrm: Remove ancient sleeping when the SA is in acquire state Steffen Klassert
2013-10-10 6:34 ` [PATCH RFC 2/2] net: Remove FLOWI_FLAG_CAN_SLEEP Steffen Klassert
2013-10-10 7:02 ` [PATCH RFC 0/2] xfrm: Remove ancient sleeping code Fan Du
2013-10-10 8:57 ` Steffen Klassert
2013-10-11 7:18 ` Fan Du
2013-10-11 9:21 ` Steffen Klassert
2013-10-11 19:01 ` David Miller
2013-10-15 7:30 ` Steffen Klassert
2013-10-15 23:14 ` David Miller
2013-10-15 23:58 ` Eric Dumazet
2013-10-16 9:45 ` Steffen Klassert
2013-10-16 11:42 ` [PATCH RFC] xfrm: Don't queue retransmitted packets if the original is still on the host Steffen Klassert
2013-10-18 20:19 ` David Miller
2013-10-18 20:23 ` Eric Dumazet
2013-10-18 20:34 ` David Miller
2013-10-21 14:51 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010063301.GO7660@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).