From: David Miller <davem@davemloft.net>
To: djduanjiong@gmail.com
Cc: inaky.perez-gonzalez@intel.com, linux-wimax@intel.com,
wimax@linuxwimax.org, netdev@vger.kernel.org,
duanj.fnst@cn.fujitsu.com
Subject: Re: [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN_ON(1)
Date: Fri, 11 Oct 2013 14:38:23 -0400 (EDT) [thread overview]
Message-ID: <20131011.143823.1482605672848878474.davem@davemloft.net> (raw)
In-Reply-To: <1381192238-6486-1-git-send-email-duanj.fnst@cn.fujitsu.com>
From: djduanjiong@gmail.com
Date: Mon, 7 Oct 2013 17:30:38 -0700
> - list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) {
> - printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
> + list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node)
> + WARN(1, KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n",
> __func__, wimax_dev, wimax_dev->net_dev->ifindex);
You are changing the column where the openning parenthesis appears by
changing the printk() into a WARN(), therefore you have to adjust the
indentation of the next line such that the arguments start at the first
column after the openning parenthesis.
prev parent reply other threads:[~2013-10-11 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:30 [PATCH] wimax: Use WARN(1,...) rather than printk followed by WARN_ON(1) djduanjiong
2013-10-11 18:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011.143823.1482605672848878474.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).