From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: f.cachereul@alphalink.fr, jchapman@katalix.com, netdev@vger.kernel.org
Subject: Re: [PATCH] l2tp: must disable bh before calling l2tp_xmit_skb()
Date: Fri, 11 Oct 2013 17:20:21 -0400 (EDT) [thread overview]
Message-ID: <20131011.172021.827876891266213757.davem@davemloft.net> (raw)
In-Reply-To: <1381411809.4971.77.camel@edumazet-glaptop.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 10 Oct 2013 06:30:09 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> François Cachereul made a very nice bug report and suspected
> the bh_lock_sock() / bh_unlok_sock() pair used in l2tp_xmit_skb() from
> process context was not good.
>
> This problem was added by commit
> ("l2tp: Fix locking in l2tp_core.c").
I added the commit SHA ID for you, please take care of this next time.
> l2tp_eth_dev_xmit() runs from BH context, so we must disable BH
> from other l2tp_xmit_skb() users.
...
> Reported-by: François Cachereul <f.cachereul@alphalink.fr>
> Tested-by: François Cachereul <f.cachereul@alphalink.fr>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks everyone.
prev parent reply other threads:[~2013-10-11 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 10:11 BUG in net/l2tp/l2tp_core.c François Cachereul
2013-10-09 11:05 ` Eric Dumazet
2013-10-10 7:37 ` François Cachereul
2013-10-10 13:30 ` [PATCH] l2tp: must disable bh before calling l2tp_xmit_skb() Eric Dumazet
2013-10-11 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011.172021.827876891266213757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=f.cachereul@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).