From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ipv6: Initialize ip6_tnl.hlen in gre tunnel even if no route is found Date: Fri, 11 Oct 2013 17:55:36 -0400 (EDT) Message-ID: <20131011.175536.1301172695781705007.davem@davemloft.net> References: <1381427427-14880-1-git-send-email-ou.ghorbel@gmail.com> <20131011150216.GA18601@order.stressinduktion.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ou.ghorbel@gmail.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: hannes@stressinduktion.org Return-path: In-Reply-To: <20131011150216.GA18601@order.stressinduktion.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Hannes Frederic Sowa Date: Fri, 11 Oct 2013 17:02:17 +0200 > On Thu, Oct 10, 2013 at 06:50:27PM +0100, Oussama Ghorbel wrote: >> The ip6_tnl.hlen (gre and ipv6 headers length) is independent from the >> outgoing interface, so it would be better to initialize it even when no >> route is found, otherwise its value will be zero. >> While I'm not sure if this could happen in real life, but doing that >> will avoid to call the skb_push function with a zero in ip6gre_header >> function. >> >> Suggested-by: Hannes Frederic Sowa >> Signed-off-by: Oussama Ghorbel > > Acked-by: Hannes Frederic Sowa Applied.