From: Stephen Hemminger <stephen@networkplumber.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] bridge: allow receiption on disabled port
Date: Fri, 11 Oct 2013 08:10:36 -0700 [thread overview]
Message-ID: <20131011081036.63eb8f28@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <5257D067.2050607@openwrt.org>
On Fri, 11 Oct 2013 12:18:15 +0200
Felix Fietkau <nbd@openwrt.org> wrote:
> On 2013-10-11 4:35 AM, Stephen Hemminger wrote:
> > This is what I was thinking would be better.
> >
> > Don't want these packets leaking into PRE_ROUTEING chain or have
> > any chance to get flooded out other ports.
> >
> > Compile tested only...
> >
> > I could use another goto instead but that becomes spaghetti and
> > never like to jump back into a block.
> [...]
> > forward:
> > switch (p->state) {
> > + case BR_STATE_DISABLED:
> > + if (!ether_addr_equal(p->br->dev->dev_addr, dest))
> > + goto drop;
> Checking against the bridge device address isn't enough, WPA EAPOL
> packets are addressed to the wifi device MAC address.
Correct, this should be skb->dev->dev_addr which matchs against
the MAC address that frame arrived on.
prev parent reply other threads:[~2013-10-11 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 12:52 [PATCH net] bridge: allow receiption on disabled port Felix Fietkau
2013-10-10 20:36 ` Stephen Hemminger
2013-10-10 20:56 ` Felix Fietkau
2013-10-10 21:52 ` Stephen Hemminger
2013-10-10 22:08 ` Felix Fietkau
2013-10-11 2:35 ` Stephen Hemminger
2013-10-11 10:18 ` Felix Fietkau
2013-10-11 15:10 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011081036.63eb8f28@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).