From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, fweisbec@gmail.com, dhowells@redhat.com,
edumazet@google.com, gaofeng@cn.fujitsu.com, mingo@kernel.org,
bridge@lists.linux-foundation.org, jmorris@namei.org,
dipankar@in.ibm.com, darren@dvhart.com, josh@joshtriplett.org,
rostedt@goodmis.org, niv@us.ibm.com,
mathieu.desnoyers@efficios.com, kuznet@ms2.inr.ac.ru,
tglx@linutronix.de, johannes@sipsolutions.net,
laijs@cn.fujitsu.com, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net,
kaber@trash.net, stephen@networkplumber.org, sbw@mit.edu,
tgraf@suug.ch, akpm@linux-foundation.org, fengguang.wu@intel.com,
davem@davemloft.net
Subject: [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13
Date: Fri, 11 Oct 2013 16:16:59 -0700 [thread overview]
Message-ID: <20131011231659.GA28062@linux.vnet.ibm.com> (raw)
Hello!
This series features updates to allow sparse to do a better job of
statically analyzing RCU usage:
1. Add a comment indicating that despite appearances,
rcu_assign_pointer() really only evaluates its arguments once,
as a cpp macro should.
2-13. Apply ACCESS_ONCE() to avoid a number of rcu_assign_pointer()
calls that would otherwise suffer sparse false positives given
patch #13 below.
14. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent
comiler mischief. Also require that the source pointer be from
the kernel address space. Sometimes it can be from the RCU address
space, which necessitates the remaining patches in this series.
Which, it must be admitted, apply to a very small fraction of
the rcu_assign_pointer() invocations in the kernel. This commit
courtesy of Josh Triplett.
Changes from v2:
o Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
the pointers are all --rcu and already visible to readers,
as suggested by Eric Dumazet and Josh Triplett.
o Place the commit adding the rcu_assign_pointer()'s ACCESS_ONCE()
at the end to allow better bisectability, as suggested by Josh
Triplett.
o Add a comment to rcu_assign_pointer() noting that it only evaluates
its arguments once, as suggested by Josh Triplett.
Changes from v1:
o Fix grammar nit in commit logs.
Thanx, Paul
b/drivers/net/bonding/bond_alb.c | 3 ++-
b/drivers/net/bonding/bond_main.c | 8 +++++---
b/include/linux/rcupdate.h | 20 +++++++++++++++++++-
b/kernel/notifier.c | 3 ++-
b/net/bridge/br_mdb.c | 2 +-
b/net/bridge/br_multicast.c | 4 ++--
b/net/decnet/dn_route.c | 8 +++++---
b/net/ipv4/ip_sockglue.c | 3 ++-
b/net/ipv6/ip6_gre.c | 3 ++-
b/net/ipv6/ip6_tunnel.c | 3 ++-
b/net/ipv6/sit.c | 3 ++-
b/net/mac80211/sta_info.c | 7 ++++---
b/net/wireless/scan.c | 32 ++++++++++++++++++--------------
13 files changed, 66 insertions(+), 33 deletions(-)
next reply other threads:[~2013-10-11 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 23:16 Paul E. McKenney [this message]
[not found] ` <1381533451-29018-1-git-send-email-paulmck@linux.vnet.ibm.com>
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 03/14] bridge: Apply ACCESS_ONCE() to avoid sparse false positive Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 04/14] wireless: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 05/14] decnet: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 06/14] ipv4/ip_socketglue: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 07/14] ipv6/ip6_tunnel: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 08/14] ipv6/ip6_gre: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 09/14] ipv6/sit: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 10/14] mac80211: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 11/14] bridge/br_mdb: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 12/14] bonding/bond_main: " Paul E. McKenney
2013-10-11 23:17 ` [PATCH v3 tip/core/rcu 13/14] bonding/bond_alb.c: " Paul E. McKenney
2013-10-12 6:53 ` [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13 Josh Triplett
2013-10-12 17:13 ` Paul E. McKenney
2013-10-12 17:39 ` [Bridge] " Hannes Frederic Sowa
2013-10-12 17:43 ` Hannes Frederic Sowa
2013-10-13 11:17 ` Paul E. McKenney
2013-10-13 11:15 ` [Bridge] " Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131011231659.GA28062@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bridge@lists.linux-foundation.org \
--cc=darren@dvhart.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=jmorris@namei.org \
--cc=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=laijs@cn.fujitsu.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).