* [patch] yam: integer underflow in yam_ioctl()
@ 2013-10-14 12:28 Dan Carpenter
2013-10-17 19:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-10-14 12:28 UTC (permalink / raw)
To: Jean-Paul Roubelat; +Cc: linux-hams, netdev, kernel-janitors
We cap bitrate at YAM_MAXBITRATE in yam_ioctl(), but it could also be
negative. I don't know the impact of using a negative bitrate but let's
prevent it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/linux/yam.h b/include/linux/yam.h
index 7fe2822..512cdc2 100644
--- a/include/linux/yam.h
+++ b/include/linux/yam.h
@@ -77,6 +77,6 @@ struct yamdrv_ioctl_cfg {
struct yamdrv_ioctl_mcs {
int cmd;
- int bitrate;
+ unsigned int bitrate;
unsigned char bits[YAM_FPGA_SIZE];
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] yam: integer underflow in yam_ioctl()
2013-10-14 12:28 [patch] yam: integer underflow in yam_ioctl() Dan Carpenter
@ 2013-10-17 19:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-10-17 19:54 UTC (permalink / raw)
To: dan.carpenter; +Cc: jpr, linux-hams, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 14 Oct 2013 15:28:38 +0300
> We cap bitrate at YAM_MAXBITRATE in yam_ioctl(), but it could also be
> negative. I don't know the impact of using a negative bitrate but let's
> prevent it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-17 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-14 12:28 [patch] yam: integer underflow in yam_ioctl() Dan Carpenter
2013-10-17 19:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).