From: Simon Horman <horms@verge.net.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
"Julian Anastasov" <ja@ssi.bg>,
"Mark Brooks" <mark@loadbalancer.org>
Subject: Re: [RFC net-next] ipv6: Use destination address determined by IPVS
Date: Wed, 16 Oct 2013 11:13:06 +0900 [thread overview]
Message-ID: <20131016021304.GA17801@verge.net.au> (raw)
In-Reply-To: <1381883949.2045.97.camel@edumazet-glaptop.roam.corp.google.com>
On Tue, Oct 15, 2013 at 05:39:09PM -0700, Eric Dumazet wrote:
> On Wed, 2013-10-16 at 09:28 +0900, Simon Horman wrote:
>
> > > I guess things like NFQUEUE could happen ?
> >
> > Could you expand a little?
>
> This was to point that between IPVS and ipv6 stack we might have a
> delay, and daddr was maybe pointed to a freed memory.
>
> IP6CB only uses 24 bytes, so I think you would be safe adding 16 bytes.
That does seem very promising but while implementing it
I hit a problem.
struct tcp_skb_cb includes a field of type struct inet6_skb_parm. And
expanding struct inet6_skb_parm by 16 bytes means that struct tcp_skb_cb is
now larger than 48 bytes and no longer fits in skb->cb.
Is it appropriate to grow skb->cb as the comment above struct tcp_skb_cb
suggests?
next prev parent reply other threads:[~2013-10-16 2:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 0:02 [RFC net-next] ipv6: Use destination address determined by IPVS Simon Horman
2013-10-16 0:13 ` Eric Dumazet
2013-10-16 0:28 ` Simon Horman
2013-10-16 0:39 ` Eric Dumazet
2013-10-16 2:13 ` Simon Horman [this message]
2013-10-16 2:40 ` Eric Dumazet
2013-10-16 4:26 ` Simon Horman
2013-10-16 0:53 ` Hannes Frederic Sowa
2013-10-16 2:14 ` Simon Horman
2013-10-16 7:27 ` Julian Anastasov
2013-10-16 14:32 ` Hannes Frederic Sowa
2013-10-16 20:22 ` Julian Anastasov
2013-10-16 21:59 ` Hannes Frederic Sowa
2013-10-16 22:50 ` Julian Anastasov
2013-10-17 23:03 ` Julian Anastasov
2013-10-18 2:10 ` Hannes Frederic Sowa
2013-10-18 6:33 ` Julian Anastasov
2013-10-18 16:33 ` Hannes Frederic Sowa
2013-10-19 16:37 ` Julian Anastasov
2013-10-19 18:34 ` Hannes Frederic Sowa
2013-10-19 22:36 ` Hannes Frederic Sowa
2013-10-19 22:39 ` Hannes Frederic Sowa
2013-10-20 7:11 ` Julian Anastasov
2013-10-20 7:33 ` Hannes Frederic Sowa
2013-10-20 8:33 ` Julian Anastasov
2013-10-20 12:27 ` Julian Anastasov
2013-10-20 6:39 ` Julian Anastasov
2013-10-20 6:47 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016021304.GA17801@verge.net.au \
--to=horms@verge.net.au \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=mark@loadbalancer.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).