netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usb: serial: option: blacklist Olivetti Olicard200
@ 2013-10-15 13:06 Enrico Mioso
  2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
  2013-10-15 14:47 ` [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Dan Williams
  0 siblings, 2 replies; 7+ messages in thread
From: Enrico Mioso @ 2013-10-15 13:06 UTC (permalink / raw)
  To: gregkh, davem, bjorn, dcbw, christian.schmiedl, linux-usb, netdev,
	linux-kernel
  Cc: Enrico Mioso, Antonella Pellizzari

Interface 6 of this device speaks QMI as per tests done by us.
Credits go to Antonella for providing the hardware.

Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 80a7104..d7c10d6 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1257,7 +1257,9 @@ static const struct usb_device_id option_ids[] = {
 
 	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100) },
 	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD145) },
-	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200) },
+	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200),
+		.driver_info = (kernel_ulong_t)&net_intf6_blacklist
+	},
 	{ USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650 CDMA 450 1xEVDO modem */
 	{ USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung GT-B3730 LTE USB modem.*/
 	{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CEM600) },
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
  2013-10-15 13:06 [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Enrico Mioso
@ 2013-10-15 13:06 ` Enrico Mioso
  2013-10-15 14:49   ` Dan Williams
                     ` (2 more replies)
  2013-10-15 14:47 ` [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Dan Williams
  1 sibling, 3 replies; 7+ messages in thread
From: Enrico Mioso @ 2013-10-15 13:06 UTC (permalink / raw)
  To: gregkh, davem, bjorn, dcbw, christian.schmiedl, linux-usb, netdev,
	linux-kernel
  Cc: Enrico Mioso, Antonella Pellizzari

This is a QMI device, manufactured by TCT Mobile Phones.
A companion patch blacklisting this device's QMI interface in the option.c
driver has been sent.

Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3d6aaf7..818ce90 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
 	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
 	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
+	{QMI_FIXED_INTF(0x0b3c, 0xc005, 6)},    /* Olivetti Olicard 200 */
 	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
 
 	/* 4. Gobi 1000 devices */
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] usb: serial: option: blacklist Olivetti Olicard200
  2013-10-15 13:06 [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Enrico Mioso
  2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
@ 2013-10-15 14:47 ` Dan Williams
  1 sibling, 0 replies; 7+ messages in thread
From: Dan Williams @ 2013-10-15 14:47 UTC (permalink / raw)
  To: Enrico Mioso
  Cc: gregkh, davem, bjorn, christian.schmiedl, linux-usb, netdev,
	linux-kernel, Antonella Pellizzari

On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
> Interface 6 of this device speaks QMI as per tests done by us.
> Credits go to Antonella for providing the hardware.
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

Tested-by: Dan Williams <dcbw@redhat.com>

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 80a7104..d7c10d6 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1257,7 +1257,9 @@ static const struct usb_device_id option_ids[] = {
>  
>  	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100) },
>  	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD145) },
> -	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200) },
> +	{ USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD200),
> +		.driver_info = (kernel_ulong_t)&net_intf6_blacklist
> +	},
>  	{ USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650 CDMA 450 1xEVDO modem */
>  	{ USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /* Samsung GT-B3730 LTE USB modem.*/
>  	{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CEM600) },

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
  2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
@ 2013-10-15 14:49   ` Dan Williams
  2013-10-15 16:07     ` Enrico Mioso
  2013-10-16 20:24   ` Greg KH
  2013-10-17 20:01   ` David Miller
  2 siblings, 1 reply; 7+ messages in thread
From: Dan Williams @ 2013-10-15 14:49 UTC (permalink / raw)
  To: Enrico Mioso
  Cc: gregkh, davem, bjorn, christian.schmiedl, linux-usb, netdev,
	linux-kernel, Antonella Pellizzari

On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

Good find.  For the record, mine has:

PX1522E16X  1  [Oct 15 2010 02:00:00]

	ctl (1.4)
	wds (1.8)
	dms (1.3)
	nas (1.2)
	qos (1.2)
	wms (1.1)
	pds (1.4)
	auth (1.0)
	voice (1.0)
	cat2 (1.1)

Tested-by: Dan Williams <dcbw@redhat.com>

> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 3d6aaf7..818ce90 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
>  	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
>  	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
> +	{QMI_FIXED_INTF(0x0b3c, 0xc005, 6)},    /* Olivetti Olicard 200 */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
>  
>  	/* 4. Gobi 1000 devices */

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
  2013-10-15 14:49   ` Dan Williams
@ 2013-10-15 16:07     ` Enrico Mioso
  0 siblings, 0 replies; 7+ messages in thread
From: Enrico Mioso @ 2013-10-15 16:07 UTC (permalink / raw)
  To: Dan Williams
  Cc: gregkh, davem, bjorn, christian.schmiedl, linux-usb, netdev,
	linux-kernel, Antonella Pellizzari

:) I'm very happy you got it working.
The firmware of our device seems so fragile still - and several QMI calls can 
bring it to a crashing state, especially when asking a network scan to the NAS 
service.


On Tue, 15 Oct 2013, Dan Williams wrote:

==Date: Tue, 15 Oct 2013 09:49:57 -0500
==From: Dan Williams <dcbw@redhat.com>
==To: Enrico Mioso <mrkiko.rs@gmail.com>
==Cc: gregkh@linuxfoundation.org, davem@davemloft.net, bjorn@mork.no,
==    christian.schmiedl@gemalto.com, linux-usb@vger.kernel.org,
==    netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
==    Antonella Pellizzari <anto.pellizzari83@gmail.com>
==Subject: Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
==
==On Tue, 2013-10-15 at 15:06 +0200, Enrico Mioso wrote:
==> This is a QMI device, manufactured by TCT Mobile Phones.
==> A companion patch blacklisting this device's QMI interface in the option.c
==> driver has been sent.
==> 
==> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
==> Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>
==
==Good find.  For the record, mine has:
==
==PX1522E16X  1  [Oct 15 2010 02:00:00]
==
==	ctl (1.4)
==	wds (1.8)
==	dms (1.3)
==	nas (1.2)
==	qos (1.2)
==	wms (1.1)
==	pds (1.4)
==	auth (1.0)
==	voice (1.0)
==	cat2 (1.1)
==
==Tested-by: Dan Williams <dcbw@redhat.com>
==
==> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
==> index 3d6aaf7..818ce90 100644
==> --- a/drivers/net/usb/qmi_wwan.c
==> +++ b/drivers/net/usb/qmi_wwan.c
==> @@ -714,6 +714,7 @@ static const struct usb_device_id products[] = {
==>  	{QMI_FIXED_INTF(0x2357, 0x0201, 4)},	/* TP-LINK HSUPA Modem MA180 */
==>  	{QMI_FIXED_INTF(0x2357, 0x9000, 4)},	/* TP-LINK MA260 */
==>  	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
==> +	{QMI_FIXED_INTF(0x0b3c, 0xc005, 6)},    /* Olivetti Olicard 200 */
==>  	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
==>  
==>  	/* 4. Gobi 1000 devices */
==
==
==

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
  2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
  2013-10-15 14:49   ` Dan Williams
@ 2013-10-16 20:24   ` Greg KH
  2013-10-17 20:01   ` David Miller
  2 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2013-10-16 20:24 UTC (permalink / raw)
  To: Enrico Mioso
  Cc: davem, bjorn, dcbw, christian.schmiedl, linux-usb, netdev,
	linux-kernel, Antonella Pellizzari

On Tue, Oct 15, 2013 at 03:06:48PM +0200, Enrico Mioso wrote:
> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] net: qmi_wwan: Olivetti Olicard 200 support
  2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
  2013-10-15 14:49   ` Dan Williams
  2013-10-16 20:24   ` Greg KH
@ 2013-10-17 20:01   ` David Miller
  2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2013-10-17 20:01 UTC (permalink / raw)
  To: mrkiko.rs
  Cc: gregkh, bjorn, dcbw, christian.schmiedl, linux-usb, netdev,
	linux-kernel, anto.pellizzari83

From: Enrico Mioso <mrkiko.rs@gmail.com>
Date: Tue, 15 Oct 2013 15:06:48 +0200

> This is a QMI device, manufactured by TCT Mobile Phones.
> A companion patch blacklisting this device's QMI interface in the option.c
> driver has been sent.
> 
> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
> Signed-off-by: Antonella Pellizzari <anto.pellizzari83@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-10-17 20:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 13:06 [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Enrico Mioso
2013-10-15 13:06 ` [PATCH] net: qmi_wwan: Olivetti Olicard 200 support Enrico Mioso
2013-10-15 14:49   ` Dan Williams
2013-10-15 16:07     ` Enrico Mioso
2013-10-16 20:24   ` Greg KH
2013-10-17 20:01   ` David Miller
2013-10-15 14:47 ` [PATCH] usb: serial: option: blacklist Olivetti Olicard200 Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).