[PATCH] net bridge: remove unused field

[PATCH] net bridge: remove unused field

[Jamal Hadi Salim]

[-- Attachment #1: Type: text/plain, Size: 29 bytes --]

Trivial patch

cheers,
jamal

[-- Attachment #2: patch-1 --]
[-- Type: text/plain, Size: 649 bytes --]

commit 984b1bc7c51a1201707238f7aa5fa1a8b72fde90
Author: jamal <jhs@mojatatu.com>
Date:   Mon Oct 14 17:04:16 2013 -0400

    Remove unused enum
    
    Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 80394e8..f8dab16 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -209,11 +209,6 @@ enum {
 #define IFLA_INET6_MAX	(__IFLA_INET6_MAX - 1)
 
 enum {
-	BRIDGE_MODE_UNSPEC,
-	BRIDGE_MODE_HAIRPIN,
-};
-
-enum {
 	IFLA_BRPORT_UNSPEC,
 	IFLA_BRPORT_STATE,	/* Spanning tree state     */
 	IFLA_BRPORT_PRIORITY,	/* "             priority  */

Re: [PATCH] net bridge: remove unused field

[David Miller]

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 14 Oct 2013 17:11:09 -0400

> Trivial patch

I know it seems rediculous, but anything we export to userspace, as we
do in this UAPI header, could be potentially be used by some piece of
source out there.

I'd rather just leave it be, you can add a comment saying it's unused
if you wish, but I'd really rather not remove it and run the risk of
breaking someone's build out there.

Thanks.

Re: [PATCH] net bridge: remove unused field

[Jamal Hadi Salim]

The only reason i made an exception of this one is because:
a) nothing in the kernel touches it
b) nothing in iproute2 touches it
c) the intended logic to transport the hairpin knob is now
in IFLA_BRPORT_MODE

But: I empathize;-> Your call

cheers,
jamal

On 10/17/13 16:10, David Miller wrote:
>
>
> I know it seems rediculous, but anything we export to userspace, as we
> do in this UAPI header, could be potentially be used by some piece of
> source out there.
>
> I'd rather just leave it be, you can add a comment saying it's unused
> if you wish, but I'd really rather not remove it and run the risk of
> breaking someone's build out there.
>
> Thanks.
>