* [PATCH] net bridge: remove unused field
@ 2013-10-14 21:11 Jamal Hadi Salim
2013-10-17 20:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jamal Hadi Salim @ 2013-10-14 21:11 UTC (permalink / raw)
To: David Miller; +Cc: Stephen Hemminger, netdev@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 29 bytes --]
Trivial patch
cheers,
jamal
[-- Attachment #2: patch-1 --]
[-- Type: text/plain, Size: 649 bytes --]
commit 984b1bc7c51a1201707238f7aa5fa1a8b72fde90
Author: jamal <jhs@mojatatu.com>
Date: Mon Oct 14 17:04:16 2013 -0400
Remove unused enum
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 80394e8..f8dab16 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -209,11 +209,6 @@ enum {
#define IFLA_INET6_MAX (__IFLA_INET6_MAX - 1)
enum {
- BRIDGE_MODE_UNSPEC,
- BRIDGE_MODE_HAIRPIN,
-};
-
-enum {
IFLA_BRPORT_UNSPEC,
IFLA_BRPORT_STATE, /* Spanning tree state */
IFLA_BRPORT_PRIORITY, /* " priority */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net bridge: remove unused field
2013-10-14 21:11 [PATCH] net bridge: remove unused field Jamal Hadi Salim
@ 2013-10-17 20:10 ` David Miller
2013-10-18 10:46 ` Jamal Hadi Salim
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-10-17 20:10 UTC (permalink / raw)
To: jhs; +Cc: shemminger, netdev
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Mon, 14 Oct 2013 17:11:09 -0400
> Trivial patch
I know it seems rediculous, but anything we export to userspace, as we
do in this UAPI header, could be potentially be used by some piece of
source out there.
I'd rather just leave it be, you can add a comment saying it's unused
if you wish, but I'd really rather not remove it and run the risk of
breaking someone's build out there.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net bridge: remove unused field
2013-10-17 20:10 ` David Miller
@ 2013-10-18 10:46 ` Jamal Hadi Salim
0 siblings, 0 replies; 3+ messages in thread
From: Jamal Hadi Salim @ 2013-10-18 10:46 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev
The only reason i made an exception of this one is because:
a) nothing in the kernel touches it
b) nothing in iproute2 touches it
c) the intended logic to transport the hairpin knob is now
in IFLA_BRPORT_MODE
But: I empathize;-> Your call
cheers,
jamal
On 10/17/13 16:10, David Miller wrote:
>
>
> I know it seems rediculous, but anything we export to userspace, as we
> do in this UAPI header, could be potentially be used by some piece of
> source out there.
>
> I'd rather just leave it be, you can add a comment saying it's unused
> if you wish, but I'd really rather not remove it and run the risk of
> breaking someone's build out there.
>
> Thanks.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-18 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-14 21:11 [PATCH] net bridge: remove unused field Jamal Hadi Salim
2013-10-17 20:10 ` David Miller
2013-10-18 10:46 ` Jamal Hadi Salim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).