From: Steffen Klassert <steffen.klassert@secunet.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH ipsec v3] xfrm: prevent ipcomp scratch buffer race condition
Date: Fri, 18 Oct 2013 11:25:12 +0200 [thread overview]
Message-ID: <20131018092512.GA31491@secunet.com> (raw)
In-Reply-To: <20131017130740.D8741E8A5E@unicorn.suse.cz>
On Thu, Oct 17, 2013 at 03:07:40PM +0200, Michal Kubecek wrote:
> In ipcomp_compress(), sortirq is enabled too early, allowing the
> per-cpu scratch buffer to be rewritten by ipcomp_decompress()
> (called on the same CPU in softirq context) between populating
> the buffer and copying the compressed data to the skb.
>
> v2: as pointed out by Steffen Klassert, if we also move the
> local_bh_disable() before reading the per-cpu pointers, we can
> get rid of get_cpu()/put_cpu().
>
> v3: removed ipcomp_decompress part (as explained by Herbert Xu,
> it cannot be called from process context), get rid of cpu
> variable (thanks to Eric Dumazet)
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Applied to the ipsec tree, thanks everyone!
next prev parent reply other threads:[~2013-10-18 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 16:03 [PATCH ipsec] xfrm: prevent ipcomp scratch buffer race condition Michal Kubecek
2013-10-15 8:33 ` Steffen Klassert
2013-10-15 8:59 ` Fan Du
2013-10-15 9:46 ` Steffen Klassert
2013-10-15 20:55 ` Michal Kubecek
2013-10-15 21:40 ` [PATCH ipsec v2] " Michal Kubecek
2013-10-15 22:44 ` Eric Dumazet
2013-10-16 12:32 ` [PATCH ipsec] " Herbert Xu
2013-10-17 9:55 ` Steffen Klassert
2013-10-17 13:07 ` [PATCH ipsec v3] " Michal Kubecek
2013-10-17 13:38 ` Eric Dumazet
2013-10-17 13:39 ` Herbert Xu
2013-10-18 9:25 ` Steffen Klassert [this message]
2013-10-18 10:54 ` [PATCH ipsec-next] xfrm: use vmalloc_node() for percpu scratches Eric Dumazet
2013-10-18 12:46 ` Herbert Xu
2013-10-21 14:48 ` Steffen Klassert
2013-10-17 11:01 ` [PATCH ipsec] xfrm: prevent ipcomp scratch buffer race condition Michal Kubecek
2013-10-17 11:04 ` Herbert Xu
2013-10-17 13:13 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018092512.GA31491@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).