From: David Miller <davem@davemloft.net>
To: freddy@asix.com.tw
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, louis@asix.com.tw, allan@asix.com.tw
Subject: Re: [PATCH 1/1] [PATCH] ax88179_178a: Correct the RX error definition in RX header
Date: Mon, 21 Oct 2013 18:55:07 -0400 (EDT) [thread overview]
Message-ID: <20131021.185507.288415528648852269.davem@davemloft.net> (raw)
In-Reply-To: <1382337460-2036-1-git-send-email-freddy@asix.com.tw>
From: freddy@asix.com.tw
Date: Mon, 21 Oct 2013 14:37:40 +0800
> From: Freddy Xin <freddy@asix.com.tw>
>
> Correct the definition of AX_RXHDR_CRC_ERR and
> AX_RXHDR_DROP_ERR. They are BIT29 and BIT31 in pkt_hdr
> seperately.
> Add VID:DID for Samsung USB Ethernet Adapter.
>
> Signed-off-by: Freddy Xin <freddy@asix.com.tw>
Do not do two logically different things in one patch.
Fix the register bit definitions in one patch, then add the
new device IDs in another.
prev parent reply other threads:[~2013-10-21 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 6:37 [PATCH 1/1] [PATCH] ax88179_178a: Correct the RX error definition in RX header freddy
2013-10-21 22:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131021.185507.288415528648852269.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allan@asix.com.tw \
--cc=freddy@asix.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=louis@asix.com.tw \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).