From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] tcp: initialize passive-side sk_pacing_rate after 3WHS Date: Mon, 21 Oct 2013 18:58:47 -0400 (EDT) Message-ID: <20131021.185847.1300529113406521142.davem@davemloft.net> References: <1382384419-6081-1-git-send-email-ncardwell@google.com> <1382387794.3284.87.camel@edumazet-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ncardwell@google.com, netdev@vger.kernel.org, edumazet@google.com, ycheng@google.com To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:44498 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905Ab3JUW6t (ORCPT ); Mon, 21 Oct 2013 18:58:49 -0400 In-Reply-To: <1382387794.3284.87.camel@edumazet-glaptop.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Mon, 21 Oct 2013 13:36:34 -0700 > On Mon, 2013-10-21 at 15:40 -0400, Neal Cardwell wrote: >> For passive TCP connections, upon receiving the ACK that completes the >> 3WHS, make sure we set our pacing rate after we get our first RTT >> sample. > >> Signed-off-by: Neal Cardwell >> Cc: Eric Dumazet >> Cc: Yuchung Cheng >> --- >> net/ipv4/tcp_input.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c >> index 53974c7..a16b01b 100644 >> --- a/net/ipv4/tcp_input.c >> +++ b/net/ipv4/tcp_input.c >> @@ -5712,6 +5712,8 @@ int tcp_rcv_state_process(struct sock *sk, struct sk_buff *skb, >> } else >> tcp_init_metrics(sk); >> >> + tcp_update_pacing_rate(sk); >> + >> /* Prevent spurious tcp_cwnd_restart() on first data packet */ >> tp->lsndtime = tcp_time_stamp; >> > > Seems good to me, thanks ! > > Acked-by: Eric Dumazet Applied, thanks everyone.