From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: mathias.krause@secunet.com, netdev@vger.kernel.org,
herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next 0/2] Removal of struct esp_data
Date: Wed, 23 Oct 2013 10:07:16 +0200 [thread overview]
Message-ID: <20131023080716.GA10148@secunet.com> (raw)
In-Reply-To: <20131022.140510.1879404122981800534.davem@davemloft.net>
On Tue, Oct 22, 2013 at 02:05:10PM -0400, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Tue, 22 Oct 2013 15:08:22 +0200
>
> > On Fri, Oct 18, 2013 at 01:55:36PM -0400, David Miller wrote:
> >> From: Mathias Krause <mathias.krause@secunet.com>
> >> Date: Fri, 18 Oct 2013 12:09:03 +0200
> >>
> >> > This series removes one level of indirection when accessing the aead
> >> > crypto algorithm in ESP transforms by simply removing struct esp_data.
> >> > This results in smaller code and less memory usage per xfrm state.
> >> >
> >> > Please apply!
> >>
> >> No objections from me, I'll let Steffen pick this up.
> >
> > I'm a bit hesitating with removing the padlen field. We resisted
> > several attempts to remove it in the past. It is currenly unused,
> > but it provides the infrastructure for ESP padding as defined
> > in RFC 4303. However, RFC 4303 recommends the use of TFC padding
> > instead to conceal the actual length of the packet. So I'm not
> > sure what's the actual usecase for ESP padding. I'll reconsider
> > this next week when I'm back at office.
>
> Steffen, is it really the case that we cannot add it back later if we
> really need to?
>
Well, I thought to either take this as a reminder to implement the
missing stuff or to take the removing patches if this is really obsolete.
I'll do one of both once I'm back from conference week in Edinburgh.
next prev parent reply other threads:[~2013-10-23 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 10:09 [PATCH net-next 0/2] Removal of struct esp_data Mathias Krause
2013-10-18 10:09 ` [PATCH net-next 1/2] net: esp{4,6}: remove padlen from " Mathias Krause
2013-10-18 10:09 ` [PATCH net-next 2/2] net: esp{4,6}: get rid of " Mathias Krause
2013-10-18 17:55 ` [PATCH net-next 0/2] Removal " David Miller
2013-10-22 13:08 ` Steffen Klassert
2013-10-22 18:05 ` David Miller
2013-10-23 8:07 ` Steffen Klassert [this message]
2013-10-23 19:40 ` David Miller
2013-10-29 12:11 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023080716.GA10148@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mathias.krause@secunet.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).