From: Veaceslav Falico <vfalico@redhat.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] net: add missing dev_put() in __netdev_adjacent_dev_insert
Date: Wed, 23 Oct 2013 15:36:52 +0200 [thread overview]
Message-ID: <20131023133652.GF25073@redhat.com> (raw)
In-Reply-To: <1382534936-23080-1-git-send-email-nikolay@redhat.com>
On Wed, Oct 23, 2013 at 03:28:56PM +0200, Nikolay Aleksandrov wrote:
>I think that a dev_put() is needed in the error path to preserve the
>proper dev refcount.
True, forgot about it. Thanks for spotting this!
Acked-by: Veaceslav Falico <vfalico@redhat.com>
>
>CC: Veaceslav Falico <vfalico@redhat.com>
>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 0918aad..bdffd65 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -4648,6 +4648,7 @@ remove_symlinks:
>
> free_adj:
> kfree(adj);
>+ dev_put(adj_dev);
>
> return ret;
> }
>--
>1.8.1.4
>
next prev parent reply other threads:[~2013-10-23 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 13:28 [PATCH net-next] net: add missing dev_put() in __netdev_adjacent_dev_insert Nikolay Aleksandrov
2013-10-23 13:36 ` Veaceslav Falico [this message]
2013-10-25 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023133652.GF25073@redhat.com \
--to=vfalico@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).