From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Cong Wang <amwang@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] fix rtnl notification in atomic context
Date: Wed, 23 Oct 2013 14:03:43 -0700 [thread overview]
Message-ID: <20131023140343.4604d80d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1382553161-3498-1-git-send-email-ast@plumgrid.com>
On Wed, 23 Oct 2013 11:32:41 -0700
Alexei Starovoitov <ast@plumgrid.com> wrote:
> +
> +void rtmsg_ifinfo(int type, struct net_device *dev, unsigned int change)
> +{
> + __rtmsg_ifinfo(type, dev, change, GFP_KERNEL);
> +}
> EXPORT_SYMBOL(rtmsg_ifinfo);
>
> static int nlmsg_populate_fdb_fill(struct sk_buff *skb,
> --
Why add another wrapper function? I think it cleaner to just change all the
callers to use the correct gfp flags.
next prev parent reply other threads:[~2013-10-23 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 18:32 [PATCH net-next] fix rtnl notification in atomic context Alexei Starovoitov
2013-10-23 21:03 ` Stephen Hemminger [this message]
2013-10-23 21:09 ` David Miller
2013-10-23 21:25 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023140343.4604d80d@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox