From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jing Wang <windsdaemon@gmail.com>
Subject: Re: [PATCH net] net: sched: Don't free f before it is allocated in route4_change
Date: Thu, 24 Oct 2013 17:41:57 +0200 [thread overview]
Message-ID: <20131024154157.GA4837@cpaasch-mac> (raw)
In-Reply-To: <1382627157.7572.59.camel@edumazet-glaptop.roam.corp.google.com>
On 24/10/13 - 08:05:57, Eric Dumazet wrote:
> On Thu, 2013-10-24 at 16:59 +0200, Christoph Paasch wrote:
> > On 24/10/13 - 07:54:33, Eric Dumazet wrote:
>
> > > I see no bug here, you missed the "goto reinsert;"
> >
> > Ups - sorry...
> >
>
> Yeah, trying to find bugs in Alexey code is really tricky ;)
Yeah :)
Instead of the goto, a simple if {} else {} would have made it
more readable IMO.
prev parent reply other threads:[~2013-10-24 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 14:50 [PATCH net] net: sched: Don't free f before it is allocated in route4_change Christoph Paasch
2013-10-24 14:54 ` Eric Dumazet
2013-10-24 14:59 ` Christoph Paasch
2013-10-24 15:05 ` Eric Dumazet
2013-10-24 15:41 ` Christoph Paasch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024154157.GA4837@cpaasch-mac \
--to=christoph.paasch@uclouvain.be \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=windsdaemon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).