From: David Miller <davem@davemloft.net>
To: hagen@jauu.net
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
edumazet@google.com, stefano.salsano@uniroma2.it,
fabio.ludovici@yahoo.it
Subject: Re: [PATCH net-next] netem: markov loss model transition fix
Date: Fri, 25 Oct 2013 19:04:09 -0400 (EDT) [thread overview]
Message-ID: <20131025.190409.1394476393722866643.davem@davemloft.net> (raw)
In-Reply-To: <1382477226-1869-1-git-send-email-hagen@jauu.net>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Tue, 22 Oct 2013 23:27:06 +0200
> The transition from markov state "3 => lost packets within a burst
> period" to "1 => successfully transmitted packets within a gap period"
> has no *additional* loss event. The loss already happen for transition
> from 1 -> 3, this additional loss will make things go wild.
>
> E.g. transition probabilities:
>
> p13: 10%
> p31: 100%
>
> Expected:
>
> Ploss = p13 / (p13 + p31)
> Ploss = ~9.09%
>
> ... but it isn't. Even worse: we get a double loss - each time.
> So simple don't return true to indicate loss, rather break and return
> false.
>
> Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Stefano Salsano <stefano.salsano@uniroma2.it>
> Cc: Fabio Ludovici <fabio.ludovici@yahoo.it>
> Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
Applied.
prev parent reply other threads:[~2013-10-25 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 21:27 [PATCH net-next] netem: markov loss model transition fix Hagen Paul Pfeifer
2013-10-25 23:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025.190409.1394476393722866643.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabio.ludovici@yahoo.it \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=stefano.salsano@uniroma2.it \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).