From: David Miller <davem@davemloft.net>
To: alistair@popple.id.au
Cc: netdev@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] ibm emac: Don't call napi_complete if napi_reschedule failed
Date: Fri, 25 Oct 2013 19:13:01 -0400 (EDT) [thread overview]
Message-ID: <20131025.191301.1496864269923138314.davem@davemloft.net> (raw)
In-Reply-To: <1382585780-13244-1-git-send-email-alistair@popple.id.au>
From: Alistair Popple <alistair@popple.id.au>
Date: Thu, 24 Oct 2013 14:36:20 +1100
> This patch fixes a bug which would trigger the BUG_ON() at
> net/core/dev.c:4156. It was found that this was due to napi_complete
> being called even when the corresponding call to napi_reschedule had
> failed.
>
> This patch ensures that we only contine processing rotting packets in
> the current mal_poll call if we are not already on the polling list.
> It also adds locking calls to protect the read-write-modify of the
> MAL_CFG DCR.
>
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
The mistaken napi_complete() call and the locking change are two different
bugs, fix them in two different patches.
next prev parent reply other threads:[~2013-10-25 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 3:36 [PATCH] ibm emac: Don't call napi_complete if napi_reschedule failed Alistair Popple
2013-10-25 23:13 ` David Miller [this message]
2013-10-29 23:53 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025.191301.1496864269923138314.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).