netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH net-next v2 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc_skb
Date: Sat, 26 Oct 2013 17:09:53 +0200	[thread overview]
Message-ID: <20131026150952.GA12817@omega> (raw)
In-Reply-To: <1382795642-12501-4-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Sat, Oct 26, 2013 at 03:54:00PM +0200, Alexander Aring wrote:
> This patch uses the netdev_alloc_skb instead dev_alloc_skb function and
> drops the seperate assignment to skb->dev.
> 
> Signed-off-by: Alexander Aring <alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Werner Almesberger <werner-SEdMjqphH88wryQfseakQg@public.gmane.org>
> ---
>  net/ieee802154/6lowpan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> index 9057f83..1884a84 100644
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -1127,12 +1127,12 @@ lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
>  
>  	lowpan_raw_dump_inline(__func__, "6lowpan fragment header", head, hlen);
>  
> -	frag = dev_alloc_skb(hlen + mlen + plen + IEEE802154_MFR_SIZE);
> +	frag = netdev_alloc_skb(skb->dev, hlen + mlen +
> +				plen + IEEE802154_MFR_SIZE);
mhh, I do the same mistake again. I will resend them.

Sorry for the noise.

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk

  parent reply	other threads:[~2013-10-26 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26 13:53 [PATCH net-next v2 0/5] 6lowpan: trivial changes Alexander Aring
2013-10-26 13:53 ` [PATCH net-next v2 1/5] 6lowpan: remove unnecessary ret variable Alexander Aring
2013-10-26 13:53 ` [PATCH net-next v2 2/5] 6lowpan: remove unnecessary check on err >= 0 Alexander Aring
     [not found] ` <1382795642-12501-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-26 13:54   ` [PATCH net-next v2 3/5] 6lowpan: use netdev_alloc_skb instead dev_alloc_skb Alexander Aring
     [not found]     ` <1382795642-12501-4-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-26 15:09       ` Alexander Aring [this message]
2013-10-26 13:54 ` [PATCH net-next v2 4/5] 6lowpan: remove skb->dev assignment Alexander Aring
2013-10-26 13:54 ` [PATCH net-next v2 5/5] 6lowpan: remove unnecessary break Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131026150952.GA12817@omega \
    --to=alex.aring-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).