From: David Miller <davem@davemloft.net>
To: dave.taht@bufferbloat.net
Cc: stephen@networkplumber.org, ncardwell@google.com,
eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: 16% regression on 10G caused by TCP small queues
Date: Sun, 27 Oct 2013 01:07:33 -0400 (EDT) [thread overview]
Message-ID: <20131027.010733.172184644367096185.davem@davemloft.net> (raw)
In-Reply-To: <20131027043351.GA27876@lists.bufferbloat.net>
From: Dave Taht <dave.taht@bufferbloat.net>
Date: Sat, 26 Oct 2013 21:33:52 -0700
> On Thu, Oct 24, 2013 at 03:01:21AM -0400, David Miller wrote:
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Date: Wed, 23 Oct 2013 21:45:57 -0700
>>
>> > Sorry, thought sk_pacing_rate depended on FQ qdisc but it is other way around.
>> > In which case doing merge of these two was sufficient to fix the problem.
>> > With a minor manual fix up to tcp.h.
>>
>> I know, I already have a half-built tree of -stable submissions
>> that does exactlty this.
>
> I know that the "fq" qdisc is not exactly a -stable thing, but if it's simpler
> to include it rather than sort through the patch sets, I'm all for it.
I'm not including 'fq' and it's absolutely not necessary to fix this
bug.
'fq' is only incidentary to this bug fix because it just so happens to
make use of sk->sk_pacing_rate. There is no other connection between
these two things.
prev parent reply other threads:[~2013-10-27 5:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 2:29 16% regression on 10G caused by TCP small queues Stephen Hemminger
2013-10-24 2:37 ` Neal Cardwell
2013-10-24 3:09 ` Stephen Hemminger
2013-10-24 3:38 ` David Miller
2013-10-24 4:45 ` Stephen Hemminger
2013-10-24 6:05 ` Eric Dumazet
2013-10-24 6:10 ` Eric Dumazet
2013-10-24 6:19 ` Eric Dumazet
2013-10-24 7:01 ` David Miller
2013-10-27 4:33 ` Dave Taht
2013-10-27 5:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027.010733.172184644367096185.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.taht@bufferbloat.net \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).