From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: fubar@us.ibm.com, andy@greyhouse.net, nikolay@redhat.com,
vfalico@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/5] bonding: patchset for rcu use in bonding
Date: Sun, 27 Oct 2013 16:37:12 -0400 (EDT) [thread overview]
Message-ID: <20131027.163712.1324471504006808112.davem@davemloft.net> (raw)
In-Reply-To: <52688F33.30904@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Thu, 24 Oct 2013 11:08:35 +0800
> The slave list will add and del by bond_master_upper_dev_link() and bond_upper_dev_unlink(),
> which will call call_netdevice_notifiers(), even it is safe to call it in write bond lock now,
> but we can't sure that whether it is safe later, because other drivers may deal NETDEV_CHANGEUPPER
> in sleep way, so I didn't admit move the bond_upper_dev_unlink() in write bond lock.
>
> now the bond_for_each_slave only protect by rtnl_lock(), maybe use bond_for_each_slave_rcu is a good
> way to protect slave list for bond, but as a system slow path, it is no need to transform bond_for_each_slave()
> to bond_for_each_slave_rcu() in slow path, so in the patchset, I will remove the unused read bond lock
> for monitor function, maybe it is a better way, I will wait to accept any relay for it.
>
> Thanks for the Veaceslav Falico opinion.
>
> v2: add and modify commit for patchset and patch, it will be the first step for the whole patchset.
Series applied, thanks.
next prev parent reply other threads:[~2013-10-27 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 3:08 [PATCH net-next v2 0/5] bonding: patchset for rcu use in bonding Ding Tianhong
2013-10-24 9:35 ` Veaceslav Falico
2013-10-27 20:37 ` David Miller [this message]
2013-10-27 21:10 ` Veaceslav Falico
2013-10-27 21:44 ` David Miller
2013-10-27 22:10 ` Veaceslav Falico
2013-10-28 4:00 ` David Miller
2013-10-27 22:53 ` Veaceslav Falico
2013-10-28 1:15 ` Ding Tianhong
2013-10-28 1:34 ` Veaceslav Falico
2013-10-28 3:02 ` Ding Tianhong
2013-10-28 4:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027.163712.1324471504006808112.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dingtianhong@huawei.com \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).