From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ast@plumgrid.com, edumazet@google.com,
stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: gso: fix truesize tracking
Date: Tue, 29 Oct 2013 00:05:36 -0400 (EDT) [thread overview]
Message-ID: <20131029.000536.2072554973179658458.davem@davemloft.net> (raw)
In-Reply-To: <1382747177.4032.21.camel@edumazet-glaptop.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 25 Oct 2013 17:26:17 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> commit 6ff50cd55545 ("tcp: gso: do not generate out of order packets")
> had an heuristic that can trigger a warning in skb_try_coalesce(),
> because skb->truesize of the gso segments were exactly set to mss.
>
> This breaks the requirement that
>
> skb->truesize >= skb->len + truesizeof(struct sk_buff);
>
> It can trivially be reproduced by :
>
> ifconfig lo mtu 1500
> ethtool -K lo tso off
> netperf
>
> As the skbs are looped into the TCP networking stack, skb_try_coalesce()
> warns us of these skb under-estimating their truesize.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Alexei Starovoitov <ast@plumgrid.com>
I decided to apply this to 'net' and queue it up for -stable,
thanks Eric!
next prev parent reply other threads:[~2013-10-29 4:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 23:37 vxlan gso is broken by stackable gso_segment() Alexei Starovoitov
2013-10-25 0:41 ` Eric Dumazet
2013-10-25 1:59 ` Alexei Starovoitov
2013-10-25 4:06 ` Eric Dumazet
2013-10-25 9:09 ` Eric Dumazet
2013-10-25 22:18 ` David Miller
2013-10-25 22:41 ` Alexei Starovoitov
2013-10-25 23:10 ` David Miller
2013-10-25 23:25 ` Eric Dumazet
2013-10-26 0:26 ` [PATCH net-next] tcp: gso: fix truesize tracking Eric Dumazet
2013-10-26 1:46 ` Alexei Starovoitov
2013-10-28 4:58 ` David Miller
2013-10-29 4:05 ` David Miller [this message]
2013-10-26 0:52 ` vxlan gso is broken by stackable gso_segment() Eric Dumazet
2013-10-26 1:25 ` [PATCH net-next] veth: extend features to support tunneling Eric Dumazet
2013-10-26 2:22 ` Alexei Starovoitov
2013-10-26 4:13 ` Eric Dumazet
2013-10-28 4:58 ` David Miller
2013-10-28 1:18 ` [PATCH net-next] inet: restore gso for vxlan Eric Dumazet
2013-10-28 4:25 ` David Miller
2013-11-07 22:33 ` Eric Dumazet
2013-11-07 23:27 ` Alexei Starovoitov
2013-11-08 0:44 ` [PATCH net-next] inet: fix a UFO regression Eric Dumazet
2013-11-08 1:39 ` Alexei Starovoitov
2013-11-08 2:08 ` Eric Dumazet
2013-11-08 2:32 ` [PATCH v2 " Eric Dumazet
2013-11-08 7:08 ` David Miller
2013-11-16 20:23 ` [PATCH net-next] inet: restore gso for vxlan Or Gerlitz
2013-11-16 20:50 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.000536.2072554973179658458.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).