From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/5] r8152 bug fixes
Date: Tue, 29 Oct 2013 00:23:17 -0400 (EDT) [thread overview]
Message-ID: <20131029.002317.345164763391263319.davem@davemloft.net> (raw)
In-Reply-To: <1382961494-2272-1-git-send-email-hayeswang@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Mon, 28 Oct 2013 19:58:09 +0800
> These could fix some driver issues.
>
> Hayes Wang (5):
> net/usb/r8152: fix tx/rx memory overflow
> net/usb/r8152: make sure the tx checksum setting is correct
> net/usb/r8152: modify the tx flow
> net/usb/r8152: fix incorrect type in assignment
> net/usb/r8152: code adjust
These are not bug fixes, some of them are just cleanups.
It is inappropriate to mix real bug fixes and non-bug fixes into
a patch series.
You must send purely the bug fixes for 'net' tree, and then later
the code cleanups and other changes targetting the 'net-next' tree.
Also, from patch #5:
====================
-Something else
====================
That is completely unacceptable. You must say what changes you are
making, the above says nothing to me nor the person reading your
commit messages in the future.
In general, your commit messages are poorly written in that they
contain not enough information for the person trying to understand
your patches at all.
prev parent reply other threads:[~2013-10-29 4:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 11:58 [PATCH 0/5] r8152 bug fixes Hayes Wang
2013-10-28 11:58 ` [PATCH 1/5] net/usb/r8152: fix tx/rx memory overflow Hayes Wang
2013-10-28 11:58 ` [PATCH 2/5] net/usb/r8152: make sure the tx checksum setting is correct Hayes Wang
2013-10-28 11:58 ` [PATCH 3/5] net/usb/r8152: modify the tx flow Hayes Wang
2013-10-28 11:58 ` [PATCH 4/5] net/usb/r8152: fix incorrect type in assignment Hayes Wang
2013-10-28 11:58 ` [PATCH 5/5] net/usb/r8152: code adjust Hayes Wang
2013-10-29 4:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.002317.345164763391263319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox