From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 08/11] openvswitch: Per cpu flow stats. Date: Tue, 29 Oct 2013 22:11:25 -0400 (EDT) Message-ID: <20131029.221125.343749464995759893.davem@davemloft.net> References: <1383092544-50599-1-git-send-email-jesse@nicira.com> <1383092544-50599-9-git-send-email-jesse@nicira.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1383092544-50599-9-git-send-email-jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org From: Jesse Gross Date: Tue, 29 Oct 2013 17:22:21 -0700 > From: Pravin B Shelar > > With mega flow implementation ovs flow can be shared between > multiple CPUs which makes stats updates highly contended > operation. Following patch allocates separate stats for each > CPU to make stats update scalable. > > Signed-off-by: Pravin B Shelar > Signed-off-by: Jesse Gross Please properly use __percpu memory for this. Using arrays for this is very strongly discouraged, please instead use the kernel facility designed exactly for this.