From: David Miller <davem@davemloft.net>
To: alistair@popple.id.au
Cc: netdev@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH 1/2] ibm emac: Don't call napi_complete if napi_reschedule failed
Date: Tue, 29 Oct 2013 22:58:21 -0400 (EDT) [thread overview]
Message-ID: <20131029.225821.1638134357101864736.davem@davemloft.net> (raw)
In-Reply-To: <1383090638-21526-1-git-send-email-alistair@popple.id.au>
From: Alistair Popple <alistair@popple.id.au>
Date: Wed, 30 Oct 2013 10:50:37 +1100
> This patch fixes a bug which would trigger the BUG_ON() at
> net/core/dev.c:4156. It was found that this was due to continuing
> processing in the current poll call even when the call to
> napi_reschedule failed, indicating the device was already on the
> polling list. This resulted in an extra call to napi_complete which
> triggered the BUG_ON().
>
> This patch ensures that we only contine processing rotting packets in
> the current mal_poll call if we are not already on the polling list.
>
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
Applied.
prev parent reply other threads:[~2013-10-30 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 23:50 [PATCH 1/2] ibm emac: Don't call napi_complete if napi_reschedule failed Alistair Popple
2013-10-29 23:50 ` [PATCH 2/2] ibm emac: Fix locking for enable/disable eob irq Alistair Popple
2013-10-30 2:58 ` David Miller
2013-10-30 2:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.225821.1638134357101864736.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).