From: David Miller <davem@davemloft.net>
To: nlhintz@hotmail.com
Cc: netdev@vger.kernel.org, zajec5@gmail.com
Subject: Re: [PATCH v2] bgmac: don't update slot on skb alloc/dma mapping error
Date: Tue, 29 Oct 2013 22:59:42 -0400 (EDT) [thread overview]
Message-ID: <20131029.225942.752679895895679051.davem@davemloft.net> (raw)
In-Reply-To: <BLU0-SMTP255BD097115C7E52E264D41AC0A0@phx.gbl>
From: Nathan Hintz <nlhintz@hotmail.com>
Date: Tue, 29 Oct 2013 19:32:01 -0700
> Don't update the slot in "bgmac_dma_rx_skb_for_slot" unless both the
> skb alloc and dma mapping are successful; and free the newly allocated
> skb if a dma mapping error occurs. This relieves the caller of the need
> to deduce/execute the appropriate cleanup action required when an error
> occurs.
>
> Signed-off-by: Nathan Hintz <nlhintz@hotmail.com>
> Acked-by: Rafał Miłecki <zajec5@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2013-10-30 2:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 2:32 [PATCH v2] bgmac: don't update slot on skb alloc/dma mapping error Nathan Hintz
2013-10-30 2:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029.225942.752679895895679051.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nlhintz@hotmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).