* [PATCH 1/2] sh_eth: check platform data pointer
@ 2013-08-31 0:23 Sergei Shtylyov
2013-09-04 6:48 ` Simon Horman
2013-10-30 19:55 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-08-31 0:23 UTC (permalink / raw)
To: netdev; +Cc: nobuhiro.iwamatsu.yj, linux-sh
Check the platform data pointer before dereferencing it and error out of the
probe() method if it's NULL.
This has additional effect of preventing kernel oops with outdated platform data
containing zero PHY address instead (such as on SolutionEngine7710).
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against Dave's 'net-next.git' repo.
drivers/net/ethernet/renesas/sh_eth.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -2653,6 +2653,12 @@ static int sh_eth_drv_probe(struct platf
pm_runtime_enable(&pdev->dev);
pm_runtime_resume(&pdev->dev);
+ if (!pd) {
+ dev_err(&pdev->dev, "no platform data\n");
+ ret = -EINVAL;
+ goto out_release;
+ }
+
/* get PHY ID */
mdp->phy_id = pd->phy;
mdp->phy_interface = pd->phy_interface;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] sh_eth: check platform data pointer
2013-08-31 0:23 [PATCH 1/2] sh_eth: check platform data pointer Sergei Shtylyov
@ 2013-09-04 6:48 ` Simon Horman
2013-10-30 19:55 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-09-04 6:48 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
On Sat, Aug 31, 2013 at 04:23:29AM +0400, Sergei Shtylyov wrote:
> Check the platform data pointer before dereferencing it and error out of the
> probe() method if it's NULL.
>
> This has additional effect of preventing kernel oops with outdated platform data
> containing zero PHY address instead (such as on SolutionEngine7710).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
>
> ---
> This patch is against Dave's 'net-next.git' repo.
>
> drivers/net/ethernet/renesas/sh_eth.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2653,6 +2653,12 @@ static int sh_eth_drv_probe(struct platf
> pm_runtime_enable(&pdev->dev);
> pm_runtime_resume(&pdev->dev);
>
> + if (!pd) {
> + dev_err(&pdev->dev, "no platform data\n");
> + ret = -EINVAL;
> + goto out_release;
> + }
> +
> /* get PHY ID */
> mdp->phy_id = pd->phy;
> mdp->phy_interface = pd->phy_interface;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] sh_eth: check platform data pointer
2013-08-31 0:23 [PATCH 1/2] sh_eth: check platform data pointer Sergei Shtylyov
2013-09-04 6:48 ` Simon Horman
@ 2013-10-30 19:55 ` Sergei Shtylyov
2013-10-30 19:16 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2013-10-30 19:55 UTC (permalink / raw)
To: netdev, David Miller; +Cc: nobuhiro.iwamatsu.yj, linux-sh
Hello.
On 08/31/2013 04:23 AM, Sergei Shtylyov wrote:
> Check the platform data pointer before dereferencing it and error out of the
> probe() method if it's NULL.
> This has additional effect of preventing kernel oops with outdated platform data
> containing zero PHY address instead (such as on SolutionEngine7710).
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> This patch is against Dave's 'net-next.git' repo.
> drivers/net/ethernet/renesas/sh_eth.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2653,6 +2653,12 @@ static int sh_eth_drv_probe(struct platf
> pm_runtime_enable(&pdev->dev);
> pm_runtime_resume(&pdev->dev);
>
> + if (!pd) {
> + dev_err(&pdev->dev, "no platform data\n");
> + ret = -EINVAL;
> + goto out_release;
> + }
> +
> /* get PHY ID */
> mdp->phy_id = pd->phy;
> mdp->phy_interface = pd->phy_interface;
David, could you please merge this patch? It has a value of its own,
regardless of the device tree support in patch 2 (which got bloked).
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] sh_eth: check platform data pointer
2013-10-30 19:55 ` Sergei Shtylyov
@ 2013-10-30 19:16 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-10-30 19:16 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 30 Oct 2013 22:55:13 +0300
> David, could you please merge this patch? It has a value of its own,
> regardless of the device tree support in patch 2 (which got bloked).
Then it needs to be resubmitted.
Any time a part of series is rejected or needs changes, it is entirely
dropped and no longer will I refer to it in patchwork.
To avoid any ambiguity, the submitted must then resubmit anythign he
wishes to be applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-30 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-31 0:23 [PATCH 1/2] sh_eth: check platform data pointer Sergei Shtylyov
2013-09-04 6:48 ` Simon Horman
2013-10-30 19:55 ` Sergei Shtylyov
2013-10-30 19:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).