From: David Miller <davem@davemloft.net>
To: ying.xue@windriver.com
Cc: David.Laight@aculab.com, maloy@donjonn.com,
Paul.Gortmaker@windriver.com, jon.maloy@ericsson.com,
erik.hugne@ericsson.com, andreas.bofjall@ericsson.com,
tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] tipc: remove two indentation levels in tipc_recv_msg routine
Date: Wed, 30 Oct 2013 16:54:43 -0400 (EDT) [thread overview]
Message-ID: <20131030.165443.2187198550218718303.davem@davemloft.net> (raw)
In-Reply-To: <1383103617-28813-1-git-send-email-ying.xue@windriver.com>
From: Ying Xue <ying.xue@windriver.com>
Date: Wed, 30 Oct 2013 11:26:57 +0800
> The message dispatching part of tipc_recv_msg() is wrapped layers of
> while/if/if/switch, causing out-of-control indentation and does not
> look very good. We reduce two indentation levels by separating the
> message dispatching from the blocks that checks link state and
> sequence numbers, allowing longer function and arg names to be
> consistently indented without wrapping. Additionally we also rename
> "cont" label to "discard" and add one new label called "unlock_discard"
> to make code clearer. In all, these are cosmetic changes that do not
> alter the operation of TIPC in any way.
>
> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
> Cc: David Laight <david.laight@aculab.com>
> Cc: Andreas Bofjäll <andreas.bofjall@ericsson.com>
> ---
> v2: Incorporated comments from David Laight and Andreas Bofjäll
This patch looks good, applied, thanks.
prev parent reply other threads:[~2013-10-30 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 3:26 [PATCH net-next v2] tipc: remove two indentation levels in tipc_recv_msg routine Ying Xue
2013-10-30 20:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030.165443.2187198550218718303.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@aculab.com \
--cc=Paul.Gortmaker@windriver.com \
--cc=andreas.bofjall@ericsson.com \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).