From: David Miller <davem@davemloft.net>
To: zajec5@gmail.com
Cc: netdev@vger.kernel.org, openwrt-devel@lists.openwrt.org,
nlhintz@hotmail.com
Subject: Re: [PATCH] bgmac: pass received packet to the netif instead of copying it
Date: Wed, 30 Oct 2013 16:58:45 -0400 (EDT) [thread overview]
Message-ID: <20131030.165845.354006604111494289.davem@davemloft.net> (raw)
In-Reply-To: <1383116400-29905-1-git-send-email-zajec5@gmail.com>
From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 30 Oct 2013 08:00:00 +0100
> Copying whole packets with skb_copy_from_linear_data_offset is a pretty
> bad idea. CPU was spending time in __copy_user_common and network
> performance was lower. With the new solution iperf-measured speed
> increased from 116Mb/s to 134Mb/s.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> Changes since [RFC TRY#2]:
> 1) Fixed arguments alignment
> 2) Dropped code fixing old slot in case of bgmac_dma_rx_skb_for_slot
> failure. Thanks to Nathan patch bgmac_dma_rx_skb_for_slot doesn't
> change anything in slot in case it failed somewhere.
Looks good, applied to net-next, thanks.
prev parent reply other threads:[~2013-10-30 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 7:00 [PATCH] bgmac: pass received packet to the netif instead of copying it Rafał Miłecki
2013-10-30 20:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030.165845.354006604111494289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nlhintz@hotmail.com \
--cc=openwrt-devel@lists.openwrt.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).