From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2 2/3] r8152: modify the tx flow
Date: Wed, 30 Oct 2013 17:04:41 -0400 (EDT) [thread overview]
Message-ID: <20131030.170441.2031802071448773661.davem@davemloft.net> (raw)
In-Reply-To: <1383117220-893-3-git-send-email-hayeswang@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Wed, 30 Oct 2013 15:13:39 +0800
> Remove the code for sending the packet in the rtl8152_start_xmit().
> Let rtl8152_start_xmit() to queue the packet only, and schedule a
> tasklet to send the queued packets. This simplify the code and make
> sure all the packet would be sent by the original order.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Basically, your driver will now queue up to 1,000 packets onto
this tx_queue list, because that is what tx_queue_len will be
for alloc_etherdev() allocated network devices.
In my previous reply to you about this patch, I asked you to
quantify and study the effects of using a limit of 60. I said
that 60 might be too large.
You've responded by removing the limit completely, which is exactly
the opposite of what I've asked you to do. Why did you do this?
This patch series is still not in a state where I can apply it,
sorry.
next prev parent reply other threads:[~2013-10-30 21:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 7:56 [PATCH net 0/3] r8152 bug fixes Hayes Wang
2013-10-29 7:56 ` [PATCH net 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-29 7:56 ` [PATCH net 2/3] r8152: modify the tx flow Hayes Wang
2013-10-29 21:49 ` David Miller
2013-10-30 3:03 ` hayeswang
2013-10-30 3:08 ` David Miller
2013-10-29 7:56 ` [PATCH net 3/3] r8152: fix incorrect type in assignment Hayes Wang
[not found] ` <1383033377-1178-1-git-send-email-hayeswang-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2013-10-30 7:13 ` [PATCH net v2 0/3] r8152 bug fixes Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 1/3] r8152: fix tx/rx memory overflow Hayes Wang
2013-10-30 7:13 ` [PATCH net v2 2/3] r8152: modify the tx flow Hayes Wang
2013-10-30 21:04 ` David Miller [this message]
2013-10-31 5:52 ` hayeswang
2013-11-04 20:53 ` David Miller
2013-11-05 12:46 ` hayeswang
2013-10-30 7:13 ` [PATCH net v2 3/3] r8152: fix incorrect type in assignment Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030.170441.2031802071448773661.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).