From: David Miller <davem@davemloft.net>
To: duanj.fnst@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: remove the unnecessary statement in find_match()
Date: Wed, 30 Oct 2013 17:08:37 -0400 (EDT) [thread overview]
Message-ID: <20131030.170837.1882918923249091614.davem@davemloft.net> (raw)
In-Reply-To: <5270B7AE.9020801@cn.fujitsu.com>
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Date: Wed, 30 Oct 2013 15:39:26 +0800
>
> After reading the function rt6_check_neigh(), we can
> know that the RT6_NUD_FAIL_SOFT can be returned only
> when the IS_ENABLE(CONFIG_IPV6_ROUTER_PREF) is false.
> so in function find_match(), there is no need to execute
> the statement !IS_ENABLED(CONFIG_IPV6_ROUTER_PREF).
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Applied to net-next, thanks.
CONFIG_IPV6_ROUTER_PREF is another good candidate for Kconfig
removal. I know we've had several bugs that only apply when
this option is on vs. off. We're maintaining two different
code paths, for really no good reason.
next prev parent reply other threads:[~2013-10-30 21:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 7:39 [PATCH] ipv6: remove the unnecessary statement in find_match() Duan Jiong
2013-10-30 9:44 ` Hannes Frederic Sowa
2013-10-30 21:08 ` David Miller [this message]
2013-10-30 21:11 ` Hannes Frederic Sowa
2013-10-31 4:22 ` David Miller
2013-10-31 6:02 ` Duan Jiong
2013-10-31 8:45 ` Hannes Frederic Sowa
2013-10-31 11:09 ` Duan Jiong
2013-10-31 11:57 ` Hannes Frederic Sowa
2013-11-01 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030.170837.1882918923249091614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).