From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: tdmackey@booleanhaiku.com, mchan@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()
Date: Wed, 30 Oct 2013 17:32:00 -0400 (EDT) [thread overview]
Message-ID: <20131030.173200.2256841895208134119.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpV6ufX5-OOrNQtsXH0_9itjU-FriOoutyKfDEWdg-irQw@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Wed, 30 Oct 2013 12:23:52 -0700
> On Tue, Oct 29, 2013 at 11:40 PM, David Miller <davem@davemloft.net> wrote:
>> From: Cong Wang <xiyou.wangcong@gmail.com>
>> Date: Tue, 29 Oct 2013 20:50:08 -0700
>>
>>> Normally ->poll() is called in softirq context, while netpoll could
>>> be called in any context depending on its caller.
>>
>> It still makes amends to make the execution context still looks
>> "compatible" as far as locking et al. is concerned.
>
> Adjusting netpoll code for IRQ context is much harder
> than just calling dev_kfree_skb_any()...
>
> What's more, we have similar change before:
>
> commit ed79bab847d8e5a2986d8ff43c49c6fb8ee3265f
> Author: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed Oct 14 14:36:43 2009 +0000
>
> virtio_net: use dev_kfree_skb_any() in free_old_xmit_skbs()
Explain to me then why other ethernet drivers implemented identically,
such as tg3, can use plain dev_kfree_skb() just fine?
next prev parent reply other threads:[~2013-10-30 21:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 22:16 [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int() David Mackey
2013-10-30 2:42 ` David Miller
2013-10-30 3:50 ` Cong Wang
2013-10-30 6:40 ` David Miller
2013-10-30 19:23 ` Cong Wang
2013-10-30 21:32 ` David Miller [this message]
2013-10-30 22:01 ` Cong Wang
2013-10-31 4:26 ` David Miller
[not found] ` <CAM_iQpXPrEj619=PRaKN4PxgOoEB96U0mLFS65AzXOezSWvhxQ@mail.gmail.com>
2013-11-01 22:01 ` David Miller
2013-11-01 23:34 ` Ben Hutchings
2013-11-02 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030.173200.2256841895208134119.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=tdmackey@booleanhaiku.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).