From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH v2 net-next] net: introduce gro_frag_list_enable sysctl Date: Wed, 30 Oct 2013 12:09:49 +0800 Message-ID: <20131030040949.GA2912@gondor.apana.org.au> References: <1383059555.5464.33.camel@edumazet-glaptop.roam.corp.google.com> <20131029.194446.2215574000648693370.davem@davemloft.net> <1383094428.4857.16.camel@edumazet-glaptop.roam.corp.google.com> <20131029.220253.1263087684709722001.davem@davemloft.net> <1383106012.4857.26.camel@edumazet-glaptop.roam.corp.google.com> <20131030040818.GB2755@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , christoph.paasch@uclouvain.be, netdev@vger.kernel.org, hkchu@google.com, mwdalton@google.com To: Eric Dumazet Return-path: Received: from ringil.hengli.com.au ([178.18.16.133]:49178 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750702Ab3J3EJw (ORCPT ); Wed, 30 Oct 2013 00:09:52 -0400 Content-Disposition: inline In-Reply-To: <20131030040818.GB2755@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Oct 30, 2013 at 12:08:18PM +0800, Herbert Xu wrote: > On Tue, Oct 29, 2013 at 09:06:52PM -0700, Eric Dumazet wrote: > > > > I am not sure 64K GRO packets that must be segmented are going to be > > faster than 22K packets without segmentation at all (TSO path on xmit) > > Indeed that is a tough call, but I think conceptually the 64K > case is much nicer than a sysctl that gets magically turned off. Also at some point we'll want to do >64K GRO/GSO too so we'll have to face this complexity one day. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt