From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: mchan@broadcom.com, tdmackey@booleanhaiku.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()
Date: Fri, 01 Nov 2013 18:01:47 -0400 (EDT) [thread overview]
Message-ID: <20131101.180147.629210014672277622.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpXPrEj619=PRaKN4PxgOoEB96U0mLFS65AzXOezSWvhxQ@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Thu, 31 Oct 2013 21:19:16 -0700
> 2013年10月30日 下午9:26于 "David Miller" <davem@davemloft.net>写道：
>>
>> We have to provide a softint compatible environment for this callback
>> to run in else everything is completely broken.
>>
>> All these drivers can safely assume softirq safe locking is
>> sufficient, you're suggesting we need to take this hardirq safety and
>> I'm really not willing to allow things to go that far. A lot of
>> effort has been expended precisely to avoid that kind of overhead and
>> cost.
>
> Alright, I am thinking to move netpoll_poll_dev() to a delayed work.
What if the printk is outputting a message that will help us discover
that work queues are deadlocked?
You can't delay the message, because every layer of indirection you
add increases the possibility that the message it never seen. You
have to do it synchronously.
next prev parent reply other threads:[~2013-11-01 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 22:16 [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int() David Mackey
2013-10-30 2:42 ` David Miller
2013-10-30 3:50 ` Cong Wang
2013-10-30 6:40 ` David Miller
2013-10-30 19:23 ` Cong Wang
2013-10-30 21:32 ` David Miller
2013-10-30 22:01 ` Cong Wang
2013-10-31 4:26 ` David Miller
[not found] ` <CAM_iQpXPrEj619=PRaKN4PxgOoEB96U0mLFS65AzXOezSWvhxQ@mail.gmail.com>
2013-11-01 22:01 ` David Miller [this message]
2013-11-01 23:34 ` Ben Hutchings
2013-11-02 5:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101.180147.629210014672277622.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=tdmackey@booleanhaiku.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).