From: David Miller <davem@davemloft.net>
To: himanshu.madhani@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com,
manish.chopra@qlogic.com
Subject: Re: [PATCH net-next 2/6] qlcnic: Replace kzalloc() with vzalloc().
Date: Sat, 02 Nov 2013 01:14:59 -0400 (EDT) [thread overview]
Message-ID: <20131102.011459.236177037024354702.davem@davemloft.net> (raw)
In-Reply-To: <4e485cb2ec05e3cae68fbf59a0f1597a95098a76.1383358893.git.himanshu.madhani@qlogic.com>
From: Himanshu Madhani <himanshu.madhani@qlogic.com>
Date: Fri, 1 Nov 2013 16:51:25 -0400
> From: Manish Chopra <manish.chopra@qlogic.com>
>
> o Some of the places kzalloc() is not required. Replace it
> with vzalloc() wherever it is not used appropriately
>
> Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
This commit message is terrible.
In what way is kzalloc() inappropriate for these allocations?
Many of them are quite small, and vzalloc() is completely inappropriate
to use in such cases.
You should only use vzalloc() for HUGE allocations, those which
kzalloc() is unable to satisfy. Many cases changed here in this
patch do not meet that criteria.
I'm tossing this entire patch series.
next prev parent reply other threads:[~2013-11-02 5:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 20:51 [PATCH net-next 0/6] qlcnic: Multiple Tx queue support and code refactoring Himanshu Madhani
2013-11-01 20:51 ` [PATCH net-next 1/6] qlcnic: Register netdev in FAILED state for 83xx/84xx Himanshu Madhani
2013-11-01 20:51 ` [PATCH net-next 2/6] qlcnic: Replace kzalloc() with vzalloc() Himanshu Madhani
2013-11-02 5:14 ` David Miller [this message]
2013-11-01 20:51 ` [PATCH net-next 3/6] qlcnic: Enhance ethtool Statistics for Multiple Tx queue Himanshu Madhani
2013-11-01 20:51 ` [PATCH net-next 4/6] qlcnic: refactor Tx/SDS ring calculation and validation in driver Himanshu Madhani
2013-11-01 20:51 ` [PATCH net-next 5/6] qlcnic: Enable multiple Tx queue support for 83xx/84xx Series adapters Himanshu Madhani
2013-11-01 20:51 ` [PATCH net-next 6/6] qlcnic: update version to 5.3.52 Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102.011459.236177037024354702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=himanshu.madhani@qlogic.com \
--cc=manish.chopra@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).