From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
alexey.orishko@gmail.com
Subject: Re: [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes
Date: Sat, 02 Nov 2013 02:02:57 -0400 (EDT) [thread overview]
Message-ID: <20131102.020257.1416912931673041539.davem@davemloft.net> (raw)
In-Reply-To: <1383301021-16613-1-git-send-email-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Fri, 1 Nov 2013 11:16:37 +0100
> This series ended up longer than expected, and it is still not
> complete. There is more to come when time allows...
>
> Most changes are trivial. Notable non-trivial changes are
> - removed filtering of identical speed notifications
> - tx_max calulation is changed to count the pad byte if
> necessary, and respect the device limit as an absolute
> upper limit even if it is too low according to the spec
> - remove the bug preventing SET_MAX_DATAGRAM_SIZE from having
> any effect
> - drop the pad-to-max if ZLPs are enabled
> - the driver specific VERSION is dropped
> - dev->hard_mtu is set to tx_max instead of max_datagram_size
> causing usbnet to calculate the qlen based on the real max
> size of tx skbs
>
> This series has been tested, along with the previously posted
> cdc_mbim series, on the NCM and MBIM devices I have:
> - Ericsson F5521gw (NCM)
> - Huawei E367 (MBIM)
> - D-Link DWM-156 A7 (MBIM w/ too low dwNtb{In,Out}MaxSize bug)
> - Sierra Wireless MC7710 (MBIM w/ ZLP and CDC Union bugs)
>
> Apart from the D-Link modem dropping a lot less oversized
> frames with the fix dedicated to it, there are no end user
> noticable functional changes as a result of this series. But
> all the non-trivial changes I listed above are of course
> detectable by users looking at that specific area (except maybe
> the removed speed notification, which requires a device sending
> duplicates to be noticable - I don't have any such device).
Looks good, series applied, thanks!
prev parent reply other threads:[~2013-11-02 6:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:16 [PATCH net-next 00/24] cdc_ncm: many small and mostly trivial fixes Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 01/24] net: cdc_ncm: simplify and optimize frame padding Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 02/24] net: cdc_ncm: add include protection to cdc_ncm.h Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 03/24] net: cdc_ncm: remove redundant "intf" field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 04/24] net: cdc_ncm: remove redundant endpoint pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 07/24] net: cdc_ncm: remove tx_speed and rx_speed fields Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 08/24] net: cdc_ncm: remove ncm_parm field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 09/24] net: cdc_ncm: fix SET_MAX_DATAGRAM_SIZE Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 10/24] net: cdc_ncm: remove descriptor pointers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 11/24] net: cdc_ncm: only the control intf can be probed Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 12/24] net: cdc_ncm: no point in filling up the NTBs if we send ZLPs Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 13/24] net: cdc_ncm: remove probe and disconnect wrappers Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 15/24] net: cdc_ncm: set correct dev->hard_mtu Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_* Bjørn Mork
2013-11-01 10:36 ` Joe Perches
2013-11-04 8:59 ` Bjørn Mork
[not found] ` <1383301021-16613-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-11-01 10:16 ` [PATCH net-next 05/24] net: cdc_ncm: remove redundant netdev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 06/24] net: cdc_ncm: remove unused udev field Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 14/24] net: cdc_ncm: remove ethtool ops Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 16/24] net: cdc_ncm: log the length we warn about Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 18/24] net: cdc_ncm: log signatures in hex Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 19/24] net: cdc_ncm: endian convert constants instead of variables Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 20/24] net: cdc_ncm: drop "extern" from header declarations Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 23/24] net: cdc_ncm: improve bind error debug messages Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 21/24] net: cdc_ncm: refactoring cdc_ncm_setup Bjørn Mork
2013-11-01 10:16 ` [PATCH net-next 22/24] net: cdc_ncm: return proper error if setup fails Bjørn Mork
2013-11-01 10:17 ` [PATCH net-next 24/24] net: cdc_ncm: no not set tx_max higher than the device supports Bjørn Mork
2013-11-02 6:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102.020257.1416912931673041539.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@gmail.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).