From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: joby.poriyath@citrix.com, bhutchings@solarflare.com,
netdev@vger.kernel.org, wei.liu2@citrix.com,
ian.campbell@citrix.com, xen-devel@lists.xen.org,
andrew.bennieston@citrix.com, david.vrabel@citrix.com,
malcolm.crossley@citrix.com
Subject: Re: [PATCH v2 net-next] net: extend net_device allocation to vmalloc()
Date: Sun, 03 Nov 2013 23:19:36 -0500 (EST) [thread overview]
Message-ID: <20131103.231936.1376432697924210356.davem@davemloft.net> (raw)
In-Reply-To: <1383163844.4857.59.camel@edumazet-glaptop.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Oct 2013 13:10:44 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Joby Poriyath provided a xen-netback patch to reduce the size of
> xenvif structure as some netdev allocation could fail under
> memory pressure/fragmentation.
>
> This patch is handling the problem at the core level, allowing
> any netdev structures to use vmalloc() if kmalloc() failed.
>
> As vmalloc() adds overhead on a critical network path, add __GFP_REPEAT
> to kzalloc() flags to do this fallback only when really needed.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Joby Poriyath <joby.poriyath@citrix.com>
> Cc: Ben Hutchings <bhutchings@solarflare.com>
> ---
> v2: change the Documentation to point to alloc_netdev_mqs()
> instead of kmalloc()/vzalloc(), from Ben
Looks good, applied, thanks Eric.
next prev parent reply other threads:[~2013-11-04 4:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 15:27 [PATCH net-next] xen-netback: allocate xenvif arrays using vzalloc Joby Poriyath
2013-10-29 15:43 ` Eric Dumazet
2013-10-29 18:46 ` Joby Poriyath
2013-10-29 23:24 ` Eric Dumazet
2013-10-29 23:32 ` Eric Dumazet
2013-10-30 10:39 ` Joby Poriyath
2013-10-30 13:54 ` Eric Dumazet
2013-10-30 15:01 ` [PATCH net-next] net: extend net_device allocation to vmalloc() Eric Dumazet
2013-10-30 19:16 ` Ben Hutchings
2013-10-30 20:09 ` Eric Dumazet
2013-10-30 20:10 ` [PATCH v2 " Eric Dumazet
2013-11-04 4:19 ` David Miller [this message]
2013-10-29 15:50 ` [PATCH net-next] xen-netback: allocate xenvif arrays using vzalloc Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131103.231936.1376432697924210356.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.bennieston@citrix.com \
--cc=bhutchings@solarflare.com \
--cc=david.vrabel@citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=joby.poriyath@citrix.com \
--cc=malcolm.crossley@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).