Re: [PATCH v4 net-next] net: introduce dev_set_forwarding()

David Miller
2013-11-07T21:17:59Z

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 4 Nov 2013 16:55:30 +0000

> On Sat, 2013-11-02 at 12:58 -0700, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> Christoph Paasch and Jerry Chu reported crashes in skb_segment() caused
>> by commit 8a29111c7ca6 ("net: gro: allow to build full sized skb")
>>
>> skb_segment() only deals with a frag_list chain containing MSS sized
>> fragments. Even if we fix this problem, its better if GRO layer
>> doesn't build skb with a frag_list in the first place, to let TSO
>> packets reaching output devices.
>>
>> David Miller and Ben Hutchings suggested we keep track of number of
>> forwarding users to be able to :
>>
>> - Disable LRO
>> - Make sure GRO layer do not use skb frag_list to extend skb capacity
>>
>> Note that after this patch, LRO is automatically re-enabled if
>> forwarding is disabled on the device, or if a device is removed
>> from a bridge.
> [...]
>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks everyone.