Re: [PATCH v3 net-next] net: introduce dev_set_forwarding()

Herbert Xu
2013-11-04T06:22:11Z

On Sun, Nov 03, 2013 at 10:05:55PM -0800, Eric Dumazet wrote:
>
> > I think we can definitely improve our behaviour the CPU-bound case.
> > Right now if we encounter something we can't hold for GRO we
> > start processing it right away. Instead we can place it in a
> > list for later processing together with the GRO packets.
> >
> > This way GRO packets are not penalised by non-GRO packets.
> >
> > You can then use the usual NAPI budget to minimise latency and
> > ensure scheduling fairness.
>
> We had these latencies only dealing with TCP packets, all GRO
> candidates.
>
> Really, I think we have used GRO at large scale here at Google ;)

So what NICs were you using that had this issue?

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt