Re: gso: Attempt to handle mega-GRO packets

Eric Dumazet
2013-11-07T02:08:44Z

On Wed, 2013-11-06 at 18:02 -0800, Eric Dumazet wrote:
> On Thu, 2013-11-07 at 09:47 +0800, Herbert Xu wrote:
>
> > Say the system is fragmented sufficiently that you'll end up with
> > 0-order pages. In that case you'll only ever be able to coalesce
> > two packets.
>
> 4K page will contain 2 frags and they will coalesce.
>
> Performance will still be quite good.
>
> We probably add a tweak, to not have any hole in this case.

After skb_page_frag_refill() call, its trivial to check if the page is
order-0.

If yes, use the whole remaining space, instead of MAX_PACKET_LEN

-> If memory is fragmented, we switch back to old behavior.

Really, its that simple.