Re: [PATCH v3 net-next] net: introduce dev_set_forwarding()

Herbert Xu
2013-11-04T07:22:05Z

On Sun, Nov 03, 2013 at 11:10:41PM -0800, Eric Dumazet wrote:
>
> Using frag_list for skb meant to be delivered to local stack is mostly
> fine. Its for forwarding that its not a win, since no driver actually
> supports frag_list and we revert to skb_segment().

Sigh.

Most of the gain these days isn't coming from the hardware anymore,
especially for virtualisation where the network stack is at least
twice as long. The gain is in paying the cost of the network once
instead of n times for an aggregation of n packets. So with your
mega-GRO patch, the choice comes down to paying for one trip or
three trips. The difference may not be trivial, even for a router.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt