Re: [PATCH v2 net-next] net: introduce gro_frag_list_enable sysctl

Herbert Xu
2013-10-30T04:20:04Z

On Tue, Oct 29, 2013 at 09:16:17PM -0700, Eric Dumazet wrote:
>
> The thing is this only matters for hosts receiving at line rate on few
> TCP flows.
>
> A router should not build too big GRO packets, as it adds latencies.
>
> Really, we had to make TSO packets being auto sized, lets not add the
> syndrome again.
>
> So I do not really understand David concern about emitting a warning.
>
> If a machine is used as a router, building GRO packets of 17 MSS is
> absolutely fine.

It's not just routers you know, we use the same code on bridges
as part of virtualisation. So it absolutely does matter.

In fact this is why I wrote GRO in the first place, to make it
work for virtualisation.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt