From: David Miller <davem@davemloft.net>
To: subramanian.vijay@gmail.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net] net: sch_red: Fix race between timer and red_destroy()
Date: Tue, 05 Nov 2013 22:16:33 -0500 (EST) [thread overview]
Message-ID: <20131105.221633.636594084725891709.davem@davemloft.net> (raw)
In-Reply-To: <1383617296-20273-1-git-send-email-subramanian.vijay@gmail.com>
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Mon, 4 Nov 2013 18:08:16 -0800
> Make sure timer does not fire once qdisc is destroyed.
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
I do not understand how this problem can trigger.
del_timer_sync() waits for all instances of the timer handler which
are running to complete, and then it deletes the timer from any of
the scheduled timer lists.
Your patch is making the mod_timer() in the timer handler conditional,
and this really shouldn't be necessary.
The whole point of del_timer_sync() is to address these kinds of
situations.
next prev parent reply other threads:[~2013-11-06 3:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 2:08 [PATCH net] net: sch_red: Fix race between timer and red_destroy() Vijay Subramanian
2013-11-06 3:16 ` David Miller [this message]
2013-11-08 21:59 ` Vijay Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105.221633.636594084725891709.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).