From: David Miller <davem@davemloft.net>
To: mathias.krause@secunet.com
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
dmitry.tarnyagin@lockless.no, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] IPsec improvements
Date: Tue, 05 Nov 2013 23:48:31 -0500 (EST) [thread overview]
Message-ID: <20131105.234831.2190193542602272571.davem@davemloft.net> (raw)
In-Reply-To: <cover.1381923854.git.mathias.krause@secunet.com>
From: Mathias Krause <mathias.krause@secunet.com>
Date: Tue, 5 Nov 2013 14:54:08 +0100
> This series moves pskb_put() to the core code -- making the code
> duplication in caif obsolete (patches 1 and 2).
>
> Additionally does this series optimize the IPsec receive path in patch 3
> by allowing skb_cow_data() to leave the buffer fragmented. I noticed the
> linearization to be a bottleneck when doing some VPN gateway benchmarks.
> Linearization of the buffer isn't needed in the receive path as the
> crypto API (and all other users of skb_cow_data) can handle sg.
>
> With patch 3 applied I was able to increase the throughput of an IPsec
> gateway from 7.12 Gbit/s to 7.28 Gbit/s.
Please deal with the feedback given to you by Ben about referring to
variables with the '@' prefix consistently in comments, then resend
this entire patch series.
Thanks.
next prev parent reply other threads:[~2013-11-06 4:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 13:54 [PATCH net-next 0/3] IPsec improvements Mathias Krause
2013-11-05 13:54 ` [PATCH net-next 1/3] net: move pskb_put() to core code Mathias Krause
2013-11-05 18:33 ` Ben Hutchings
2013-11-06 9:01 ` Mathias Krause
2013-11-05 13:54 ` [PATCH net-next 2/3] caif: use pskb_put() instead of reimplementing its functionality Mathias Krause
2013-11-05 13:54 ` [PATCH net-next 3/3] net: allow to leave the buffer fragmented in skb_cow_data() Mathias Krause
2013-11-05 14:33 ` Eric Dumazet
2013-11-05 14:43 ` Mathias Krause
2013-11-06 9:30 ` Herbert Xu
2013-11-06 9:49 ` Mathias Krause
2013-11-06 9:52 ` Herbert Xu
2013-11-06 12:42 ` Mathias Krause
2013-11-06 12:48 ` Herbert Xu
2013-11-06 16:39 ` Eric Dumazet
2013-11-07 8:56 ` Mathias Krause
2013-11-07 8:55 ` Mathias Krause
2013-11-07 9:01 ` Herbert Xu
2013-11-07 10:01 ` Mathias Krause
2013-11-06 4:48 ` David Miller [this message]
2013-11-06 9:02 ` [PATCH net-next 0/3] IPsec improvements Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105.234831.2190193542602272571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=herbert@gondor.apana.org.au \
--cc=mathias.krause@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).