From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Florent Fourcot <florent.fourcot@enst-bretagne.fr>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt
Date: Tue, 5 Nov 2013 17:22:25 +0100 [thread overview]
Message-ID: <20131105162225.GI8832@order.stressinduktion.org> (raw)
In-Reply-To: <20131105160838.GH8832@order.stressinduktion.org>
On Tue, Nov 05, 2013 at 05:08:38PM +0100, Hannes Frederic Sowa wrote:
> On Tue, Nov 05, 2013 at 03:28:56PM +0100, Florent Fourcot wrote:
> > + spin_lock_bh(&ip6_fl_lock);
> > + rcu_read_lock_bh();
> > +
> > + for_each_sk_fl_rcu(np, sfl) {
> > + if (sfl->fl->label == (np->flow_label & IPV6_FLOWLABEL_MASK)) {
>
> The iteration is protected by rcu, so need to take the ip6_fl_lock. We should
^no ^ here.
Sorry,
Hannes
next prev parent reply other threads:[~2013-11-05 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 14:28 [PATCH net-next v3 1/4] ipv6: remove old conditions on flow label sharing Florent Fourcot
2013-11-05 14:28 ` [PATCH net-next v2 2/4] ipv6: enable IPV6_FLOWLABEL_MGR for getsockopt Florent Fourcot
2013-11-05 16:08 ` Hannes Frederic Sowa
2013-11-05 16:22 ` Hannes Frederic Sowa [this message]
2013-11-05 14:28 ` [PATCH net-next 3/4] ipv6: increase maximum lifetime of flow labels Florent Fourcot
2013-11-05 14:28 ` [PATCH net-next 4/4] ipv6: protect flow label renew against GC Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131105162225.GI8832@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=florent.fourcot@enst-bretagne.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox