From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, pablo@netfilter.org,
netfilter-devel@vger.kernel.org, yoshfuji@linux-ipv6.org,
kadlec@blackhole.kfki.hu, kaber@trash.net, mleitner@redhat.com,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, wensong@linux-vs.org,
horms@verge.net.au, ja@ssi.bg, edumazet@google.com,
pshelar@nicira.com, jasowang@redhat.com,
alexander.h.duyck@intel.com, fw@strlen.de
Subject: Re: [patch net-next 1/2] ip6_output: fragment outgoing reassembled skb properly
Date: Thu, 07 Nov 2013 18:54:53 -0500 (EST) [thread overview]
Message-ID: <20131107.185453.1341640661253119352.davem@davemloft.net> (raw)
In-Reply-To: <1383756740-7392-2-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 6 Nov 2013 17:52:19 +0100
> If reassembled packet would fit into outdev MTU, it is not fragmented
> according the original frag size and it is send as single big packet.
>
> The second case is if skb is gso. In that case fragmentation does not happen
> according to the original frag size.
>
> This patch fixes these.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
...
> if ((skb->len > ip6_skb_dst_mtu(skb) && !skb_is_gso(skb)) ||
> - dst_allfrag(skb_dst(skb)))
> + dst_allfrag(skb_dst(skb)) ||
> + (IP6CB(skb)->frag_max_size && skb->len > IP6CB(skb)->frag_max_size))
> return ip6_fragment(skb, ip6_finish_output2);
Jiri are you sure that you don't need to take GSO into account in the
new part you are adding to the test?
next prev parent reply other threads:[~2013-11-07 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 16:52 [patch net-next 0/2] netfilter: push reasm skb through instead of original frag skbs Jiri Pirko
2013-11-06 16:52 ` [patch net-next 1/2] ip6_output: fragment outgoing reassembled skb properly Jiri Pirko
2013-11-07 23:54 ` David Miller [this message]
2013-11-08 7:52 ` Jiri Pirko
2013-11-08 19:49 ` David Miller
2013-11-08 22:20 ` Hannes Frederic Sowa
2013-11-09 11:00 ` Jiri Pirko
2013-11-11 5:47 ` David Miller
2013-11-06 16:52 ` [patch net-next 2/2] netfilter: push reasm skb through instead of original frag skbs Jiri Pirko
2013-11-06 22:17 ` Julian Anastasov
2013-11-07 12:52 ` Marcelo Ricardo Leitner
2013-11-11 5:47 ` [patch net-next 0/2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107.185453.1341640661253119352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
--cc=wensong@linux-vs.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).