* [patch] isdn: icn: NULL dereference printing error message
@ 2013-11-07 7:58 Dan Carpenter
2013-11-08 0:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-07 7:58 UTC (permalink / raw)
To: netdev, Karsten Keil; +Cc: David S. Miller, isdn4linux, kernel-janitors
"card2" is NULL here so I have changed it to use "id2" instead of
"card2->interface.id".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c
index e74df7c..53d487f 100644
--- a/drivers/isdn/icn/icn.c
+++ b/drivers/isdn/icn/icn.c
@@ -1580,8 +1580,7 @@ icn_addcard(int port, char *id1, char *id2)
}
if (!(card2 = icn_initcard(port, id2))) {
printk(KERN_INFO
- "icn: (%s) half ICN-4B, port 0x%x added\n",
- card2->interface.id, port);
+ "icn: (%s) half ICN-4B, port 0x%x added\n", id2, port);
return 0;
}
card->doubleS0 = 1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] isdn: icn: NULL dereference printing error message
2013-11-07 7:58 [patch] isdn: icn: NULL dereference printing error message Dan Carpenter
@ 2013-11-08 0:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-11-08 0:14 UTC (permalink / raw)
To: dan.carpenter; +Cc: netdev, isdn, isdn4linux, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 7 Nov 2013 10:58:06 +0300
> "card2" is NULL here so I have changed it to use "id2" instead of
> "card2->interface.id".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-08 0:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-07 7:58 [patch] isdn: icn: NULL dereference printing error message Dan Carpenter
2013-11-08 0:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).