From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] net: make ndev->irq signed for error handling
Date: Thu, 7 Nov 2013 04:22:49 -0800 (PST) [thread overview]
Message-ID: <20131107122249.GN20521@mwanda> (raw)
In-Reply-To: <527B842E.2060909@ti.com>
On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote:
> On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote:
> > There is a bug in cpsw_probe() where we do:
> >
> > ndev->irq = platform_get_irq(pdev, 0);
> > if (ndev->irq < 0) {
> >
> > The problem is that "ndev->irq" is unsigned so the error handling
> > doesn't work. I have changed it to a regular int.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ndev->irq is never used any where in the driver, I think its better to
> remove this part of code from probe. If every one is ok, I can send a
> patch to remove the code.
It seems like cpsw_ndo_poll_controller() uses it.
regards,
dan carpenter
next prev parent reply other threads:[~2013-11-07 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 7:48 [patch] net: make ndev->irq signed for error handling Dan Carpenter
2013-11-07 12:14 ` Mugunthan V N
2013-11-07 12:22 ` Dan Carpenter [this message]
2013-11-07 16:33 ` Mugunthan V N
2013-11-08 8:41 ` Dan Carpenter
2013-11-08 9:18 ` Mugunthan V N
2013-11-08 0:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107122249.GN20521@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).