From: Matthew Whitehead <tedheadster@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature
Date: Thu, 7 Nov 2013 16:55:43 -0500 [thread overview]
Message-ID: <20131107215543.GA28687@mwhitehe.csb> (raw)
In-Reply-To: <1383860994.9263.31.camel@joe-AO722>
> I think that's OK if/when there are multiple statements
> in a block after the netif_msg_<type> like:
>
> if (netif_msg_rx_err(ei_local)) {
> foo();
> bar();
> }
>
> > I did a V2 in this style, but I'll change it to
> >
> > netif_<level>(struct ei_device *, type, struct net_device *, fmt, ...)
> >
> > if that is the more preferred style
>
> Otherwise I think netif_<level> is the "more preferred" style.
>
>
Joe,
I'll do another version using netif_<level> and post it as V2.
- Matthew
prev parent reply other threads:[~2013-11-07 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 20:56 [PATCH net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature Matthew Whitehead
2013-11-06 23:49 ` Joe Perches
2013-11-07 21:42 ` Matthew Whitehead
2013-11-07 21:49 ` Joe Perches
2013-11-07 21:55 ` Matthew Whitehead [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107215543.GA28687@mwhitehe.csb \
--to=tedheadster@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).